This repository has been archived by the owner on Oct 10, 2024. It is now read-only.
fix: use type from the reply nested content directly #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ae4fcda The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dmccartney
force-pushed
the
daniel-reply-nested-type
branch
from
a1a32e1
to
6cb5ed8
Compare
neekolas
approved these changes
Aug 21, 2023
rygine
reviewed
Aug 21, 2023
rygine
reviewed
Aug 21, 2023
|
we also need to add a changeset to this PR so that the changes are published to NPM. there's a link above in the comment by |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets the nested type of a reply from the deserialized EncodedContent instead of inspecting the parameter map.
See also
xmtp/xmtp-ios#143
xmtp/xmtp-android#104
This is all part of
xmtp/xmtp-react-native#81