Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch: improve setup and logging for wrp validators #418

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

denopink
Copy link
Contributor

@denopink denopink commented Oct 9, 2024

  • improve logging structure for validator errors
  • error out during server setup if any validator metric fail to init

- improve logging structure for validator errors
- error out during server setup if any validator metric fail to init
@denopink denopink self-assigned this Oct 9, 2024
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.

Project coverage is 19.09%. Comparing base (d8f1c77) to head (750c5ab).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
primaryHandler.go 0.00% 24 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #418      +/-   ##
==========================================
- Coverage   19.58%   19.09%   -0.50%     
==========================================
  Files           7        7              
  Lines         623      639      +16     
==========================================
  Hits          122      122              
- Misses        499      515      +16     
  Partials        2        2              
Flag Coverage Δ
unittests 19.09% <0.00%> (-0.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@denopink denopink merged commit d71aa9b into main Oct 9, 2024
17 of 19 checks passed
@denopink denopink deleted the denopink/wrp-validators/improve-logging-and-setup branch October 9, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant