Update CMake minimum version, silence compiler warnings #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some subdirectories had a higher minimum version specified. This is now 'propagated'. Also, compatibily with newer CMake versions is now explicity stated.
|
@sezero: In commit cdcf0d5 you made it possible to build the project with CMake 3.5. It seems this has been broken for years, and it seems that since commit 0dfe235 (which was made only a month after your commit) CMake 3.12 is actually required. Are there any good reasons to keep supporting CMake 3.11 and earlier at this point? It seems nobody complained in the last 5 years? |
|
I guess bumping min required version (to 3.12 or something) should be OK these days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #774