[BugFix] Fix commit transaction not in write lock in replication job

Signed-off-by: xiangguangyxg <[email protected]>
xiangguangyxg · Dec 19, 2024 · b4a1a62 · b4a1a62
1 parent 367311b
commit b4a1a62
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/fe/fe-core/src/main/java/com/starrocks/replication/ReplicationJob.java b/fe/fe-core/src/main/java/com/starrocks/replication/ReplicationJob.java
@@ -841,8 +841,14 @@ private void commitTransaction() throws StarRocksException {
         ReplicationTxnCommitAttachment attachment = new ReplicationTxnCommitAttachment(
                 partitionVersions, partitionVersionEpochs);
 
-        GlobalStateMgr.getServingState().getGlobalTransactionMgr().commitTransaction(databaseId,
-                transactionId, tabletsCommitInfo.first, tabletsCommitInfo.second, attachment);
+        Locker locker = new Locker();
+        locker.lockTableWithIntensiveDbLock(databaseId, tableId, LockType.WRITE);
+        try {
+            GlobalStateMgr.getServingState().getGlobalTransactionMgr().commitTransaction(databaseId,
+                    transactionId, tabletsCommitInfo.first, tabletsCommitInfo.second, attachment);
+        } finally {
+            locker.unLockTableWithIntensiveDbLock(databaseId, tableId, LockType.WRITE);
+        }
     }
 
     private void abortTransaction(String reason) {