Skip to content
This repository has been archived by the owner on Dec 12, 2020. It is now read-only.

Releases Browser #78

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from
Draft

Releases Browser #78

wants to merge 12 commits into from

Conversation

defvs
Copy link
Collaborator

@defvs defvs commented Aug 11, 2019

Adds a release browser which shows album arts, releases names and artists, and can show one release's tracks in a beautiful manner.

Current progress :

Videos of the latest progress

Newest video with enhancements

https://streamable.com/hdct3

Old but shows some features the first vid doesn't

https://streamable.com/flzmg

Browser :

unknown

  • Shows cover arts
  • Only shows high-res if already in the cache (still figuring out how to deal with it, how about creating a new cached size ? 512 or 256 should be plenty, 64 is a bit small and 1024 is way too much)
  • Size of covers can be changed to show more or less releases at once
  • Gold previews are shown with a gold border
  • You can hover a release to see the full title in case it's too long and cut

Draft for release view (once you click a release) :

DeepinScreenshot_select-area_20190811230648

  • Clicking "Download" will tick the related box in the downloader
  • Clicking "Play" or "Add to Playlist" will use Add Autoplay / Playlists #15 in the near future
  • Cover will be high-res 512x512 probably

Ideas / TODO

  • Other viewing methods such as a ListView
  • Check in Downloader : Hard to do, SongView is a class and I need a reference.
  • Add to playlist : Requires Add Autoplay / Playlists #15

@defvs
Copy link
Collaborator Author

defvs commented Aug 11, 2019

The release view is very complex. I've tested FXML a bit but I don't like it, I'll do it programatically then.

@defvs
Copy link
Collaborator Author

defvs commented Aug 11, 2019

Also, the blur is just here till we figure out what cover size we use. It's currently using the 64px thumbnails which are horrible. I think I'll create a new cached size, 256px. It's the "good" size, not too large, not too small.

@xeruf
Copy link
Owner

xeruf commented Aug 12, 2019

Hmm, I'd support going with FXML, I was already thinking about implementing it for the main app as well, because then you can easily implement different layouts without changing the actual codeand it forces you to decouple unrelated stuff.

@xeruf
Copy link
Owner

xeruf commented Aug 12, 2019

But in general I like this initiative 👍
It would be nice if you could have different views for viewing the Releases, now it's only a Grid, maybe resize the Grid, add a List View etc. FXML could be useful in that regard.

@xeruf
Copy link
Owner

xeruf commented Aug 12, 2019

About icon size - you can just make the grid items smaller for now. We'll have to make cover caching smarter sooner or later anyways, then we can tackle this as well.

@defvs
Copy link
Collaborator Author

defvs commented Aug 12, 2019

But in general I like this initiative +1
It would be nice if you could have different views for viewing the Releases, now it's only a Grid, maybe resize the Grid, add a List View etc. FXML could be useful in that regard.

Good idea.

About icon size - you can just make the grid items smaller for now. We'll have to make cover caching smarter sooner or later anyways, then we can tackle this as well.

I'll make the "default" grid size smaller, you'll still be able to change it with buttons (which are not visible in the screenshot, its pretty outdated)

@defvs defvs self-assigned this Aug 12, 2019
@defvs defvs added enhancement New feature front-end Stuff you can see labels Aug 12, 2019
@defvs
Copy link
Collaborator Author

defvs commented Sep 17, 2019

Can you merge xeruf/util#7 ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature front-end Stuff you can see
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants