This repository has been archived by the owner on Dec 12, 2020. It is now read-only.
fix(catalog-tab): genre colors not appearing anymore #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MCatalog changed a few things in the sheet so genre colors were broken:
I don't feel good about these changes but well it's their thing.
This fixes the genre colors not being applied because the column is now named "Label" instead. I also cleaned up the column list to get rid of the "column not found" warning.
Had to add exceptions to the genreColors map because your implementation of RoughMap does a search by checking if the input string is contained in any of the keys; this caused issues with "EP" since it's contained within "Drumstep".
Also cleaned up the code a tiny bit