fix #507: Add tests on JDK 8, 11, and 17 to fix missing method (java.…

…nio.file.Path.of) error (#508) * Test on JDK 8, 11, and 17 * Use Paths.get **Problem** Path.of doesn't exist on JDK 8. **Solution** Use Paths.get.
xerial · Aug 19, 2024 · 7824290 · 7824290
1 parent c0c099b
commit 7824290
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 18 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -14,25 +14,30 @@ jobs:
       - uses: actions/checkout@v4
       - name: scalafmt
         run: ./sbt scalafmtCheckAll
-  test_jdk11:
-    name: Test JDK11
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v4
-      - uses: actions/setup-java@v4
-        with:
-          distribution: 'temurin'
-          java-version: 11
-      - name: sbt scripted test
-        run: ./sbt compile scripted
-  test_jdk17:
-    name: Test JDK17
-    runs-on: ubuntu-latest
+  test:
+    name: Test
+    strategy:
+      fail-fast: false
+      matrix:
+        include:
+          - os: ubuntu-latest
+            distribution: zulu
+            java: 8
+          - os: ubuntu-latest
+            distribution: temurin
+            java: 11
+          - os: ubuntu-latest
+            distribution: temurin
+            java: 17
+          - os: windows-latest
+            distribution: temurin
+            java: 17
+    runs-on: ${{ matrix.os }}
     steps:
       - uses: actions/checkout@v4
       - uses: actions/setup-java@v4
         with:
-          distribution:	'temurin'
-          java-version:	17
+          distribution: "${{ matrix.distribution }}"
+          java-version: "${{ matrix.java }}"
       - name: sbt scripted test
         run: ./sbt compile scripted
diff --git a/src/main/scala/xerial/sbt/sonatype/SonatypeCentralService.scala b/src/main/scala/xerial/sbt/sonatype/SonatypeCentralService.scala
@@ -2,7 +2,7 @@ package xerial.sbt.sonatype
 
 import com.lumidion.sonatype.central.client.core.{DeploymentName, PublishingType}
 import java.io.{File, FileInputStream, FileOutputStream}
-import java.nio.file.{Files, Path}
+import java.nio.file.{Files, Path, Paths}
 import java.util.zip.{ZipEntry, ZipOutputStream}
 import scala.util.Try
 import wvlet.log.LogSupport
@@ -16,7 +16,7 @@ private[sbt] class SonatypeCentralService(client: SonatypeCentralClient) extends
       deploymentName: DeploymentName,
       publishingType: PublishingType
   ): Either[SonatypeException, Unit] = for {
-    bundleZipDirectory <- Try(Files.createDirectory(Path.of(s"${localBundlePath.getPath}-bundle"))).toEither.leftMap {
+    bundleZipDirectory <- Try(Files.createDirectory(Paths.get(s"${localBundlePath.getPath}-bundle"))).toEither.leftMap {
       err =>
         SonatypeException(BUNDLE_ZIP_ERROR, s"Error creating bundle zip directory. ${err.getMessage}")
     }