Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kernel/IO] Implemented XFileRenameInformation #1742

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Gliniak
Copy link
Member

@Gliniak Gliniak commented Jan 24, 2021

TLDR: Some games uses XFileRenameInformation to rename savefiles adhoc.

I'm pulling it as draft. I'm not sure if everything works as intended and have proper names.

There is for sure missing path validation, but I had no idea where to put that function to be available where it is requred.

Affected Titles:

Nascar: Inside Line - Fixes Saving
Blue Dragon - Fixes icons in menu while cache partition is active
Mass Effect - Fixes Saving

@Gliniak Gliniak force-pushed the XFileRenameInformationSupport branch 2 times, most recently from 824f779 to c49ea67 Compare May 23, 2021 09:24
@Gliniak Gliniak force-pushed the XFileRenameInformationSupport branch from c49ea67 to 9808b99 Compare September 20, 2021 10:39
aerisarn added a commit to aerisarn/xenia that referenced this pull request Jan 3, 2024
aerisarn added a commit to aerisarn/xenia that referenced this pull request Jan 9, 2024
@Regunavailable
Copy link

Regunavailable commented Jan 29, 2024

still trynna find fixes for this gamee nascar that is

@Gliniak
Copy link
Member Author

Gliniak commented Jan 29, 2024

still trynna find fixes for this gamee nascar that is

I will add improved version to canary soon

@Gliniak
Copy link
Member Author

Gliniak commented Jan 29, 2024

(for future reference, when I will manage to write it even better)
Added to canary:
xenia-canary@74b5271

A bit simplified and works in more cases, but still isn't perfect.

Issues:

  • Providing only filename as a path might cause it to crash. I haven't seen such case in games that use it, but it might be required in the future.
  • Exposing host_path (package root) to host entry

@Regunavailable
Copy link

Welp, thanks for the work! I can enjoy NASCAR now but problem is I get an Error "Lost GPU Driver (Due to internal error) I switch to Vulkan but the game looks Deep fried and vulkan just completely breaks the graphics. This is why we cannot have nice things.

@Regunavailable
Copy link

Update Game works fine and you CAN race about 1 time until you start getting Graphical bugs and it will just Crash because it "lost" the Graphics driver. I can choose Vulkan but I have to sacrifice the game looking like Sh*t.. I'll continue waiting for a fix If Possible That is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants