rpi5: add pinctrl and scmi pinctrl Pin control protocol support #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrygiriiS
force-pushed
the
scmi_pinctrl
branch
2 times, most recently
from
f567b45
to
923e777
Compare
GrygiriiS
changed the title
|
Ready for review. |
oleksiimoisieiev
suggested changes
Aug 19, 2024
|
|
||
| uint16_t pinctrl_get_groups_count() | ||
| { | ||
| return 0; |
There was a problem hiding this comment.
I think here and below should be -ENOTSUP
There was a problem hiding this comment.
No get _count should return 0 as safe value.
GrygiriiS
force-pushed
the
scmi_pinctrl
branch
from
923e777
to
8a00a45
Compare
GrygiriiS
force-pushed
the
scmi_pinctrl
branch
2 times, most recently
from
15257e0
to
dd1ee9a
Compare
This defines the generic interface, and ops, which should provide the platform specific implementation of pin control subsystem. This driver was designed to be used from agents via SCP, as well as from the other drivers, which requires pins configuration. Signed-off-by: Oleksii Moisieiev <[email protected]> Signed-off-by: Grygorii Strashko <[email protected]>
Add RPI5 BCM2712 pinctrl driver. Signed-off-by: Grygorii Strashko <[email protected]>
Add ARM SCMI Pin control protocol implementation according to the SCMI spec v3.2. Limitation: - PINCTRL_SETTINGS_GET supports only one Config per request. Signed-off-by: Grygorii Strashko <[email protected]> Signed-off-by: Oleksii Moisieiev <[email protected]>
Enable ARM SCMI Pin control protocol for RPI5. Signed-off-by: Grygorii Strashko <[email protected]>
GrygiriiS
force-pushed
the
scmi_pinctrl
branch
from
dd1ee9a
to
a43cf84
Compare
|
Optimized generic pinctrl interface |
|
LGTM |
|
Closed as all work is now done in PR #18 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the PR #14
tested with https://github.com/GrygiriiS/linux/commits/gs_scmi_pinctrl_am_1/
Not tested under XEN as it depends on:
ARM TF #16
XEN xen-troops/xen#209