Fix passing alt key as cmd to webkit caused by a misunderstanding by me

xeco23 · Feb 24, 2023 · 74f5e7a · 74f5e7a
1 parent 7ce2894
commit 74f5e7a
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 13 deletions.
diff --git a/src/ui/MainWindow.cpp b/src/ui/MainWindow.cpp
@@ -164,6 +164,13 @@ namespace wfl::ui
             }
         }
 
+        // This is required for keyboard shortcuts on WhatsApp Web to work. Since it is running
+        // on WebKit, WhatsApp Web listens for Mac's [CMD] key instead of the standard [ALT] key.
+        if (keyEvent->state & GDK_MOD1_MASK)
+        {
+            keyEvent->state |= GDK_META_MASK;
+        }
+
         return Gtk::ApplicationWindow::on_key_press_event(keyEvent);
     }
 

diff --git a/src/ui/WebView.cpp b/src/ui/WebView.cpp
@@ -338,14 +338,4 @@ namespace wfl::ui
 
         return true;
     }
-
-    bool WebView::on_key_press_event(GdkEventKey* keyEvent)
-    {
-        // This is required for keyboard shortcuts on WhatsApp Web to work. Since it is running
-        // on WebKit, WhatsApp Web listens for Mac's [CMD] key instead of the standard [ALT] key.
-        if (keyEvent->state & GDK_MOD1_MASK)
-            keyEvent->state += GDK_META_MASK;
-
-        return Gtk::Widget::on_key_press_event(keyEvent);
-    }
 }
diff --git a/src/ui/WebView.hpp b/src/ui/WebView.hpp
@@ -35,9 +35,6 @@ namespace wfl::ui
             sigc::signal<void, bool>            signalNotification() const noexcept;
             sigc::signal<void>                  signalNotificationClicked() const noexcept;
 
-        protected:
-            bool on_key_press_event(GdkEventKey* keyEvent) override;
-
         private:
             void onLoadStatusChanged(WebKitLoadEvent loadEvent);
             bool onTimeout();