feat: support for data stores #192
Conversation
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
👋 xavidop your PR is conflicting and needs to be updated to be merged |
|
👋 xavidop your PR is conflicting and needs to be updated to be merged |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
cmd/datastore/delete.go (1)
12-12: Correct the doc comment to accurately reflect the command purpose.The current comment says “search datastore set command,” but this command is for deleting a datastore.
-// deleteCmd represents the search datastore set command +// deleteCmd represents the delete datastore command
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
cmd/datastore/delete.go(1 hunks)
🔇 Additional comments (2)
cmd/datastore/delete.go (2)
24-25: Add more context to the error message.
This issue was previously flagged with the same suggestion. Provide a more descriptive error message for clarity.
- global.Log.Errorf("%s", err.Error())
+ global.Log.Errorf("failed to delete datastore: %v", err)36-50: Consider adding test coverage for deleteCmd.
Currently, there are no unit tests for the datastore deletion flow. Testing each path, including error scenarios, ensures reliability and prevents regressions.
Do you want me to generate an initial test file for this command?
|
👋 xavidop your PR is conflicting and needs to be updated to be merged |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Summary by CodeRabbit
New Features
cxcli datastorecommand for managing datastores.cxcli datastore searchcommand for searching within datastores.cxcli.Documentation
cxcli datastoreandcxcli datastore searchcommands.Development Environment
General Updates
Summary by CodeRabbit
New Features
cxcli datastorecommand for managing datastore operations.Bug Fixes
Documentation
cxcli datastorecommands and datastore operations.Chores
.coderabbit.yamlfor review configurations.anchore/sbom-action/download-syft.docs/requirements.txt.