[feature] Allow multiple sites for sitemaps #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soul4code
changed the title
soul4code
changed the title
|
Hi, this looks awsome! However, I need you to update README as well, please mention how to use this new stuff. Once that is provided, I will gladly merge this. |
xaralis
reviewed
Oct 20, 2018
| @@ -71,8 +77,7 @@ def get_url(): | |||
| elif settings.STATIC_URL.startswith('/'): | |||
| # If STATIC_URL starts with '/', it is probably a relative URL to the | |||
| # current domain so we append STATIC_URL. | |||
| from django.contrib.sites.models import Site | |||
| _url = Site.objects.get_current().domain + settings.STATIC_URL | |||
| _url = site.domain + settings.STATIC_URL + site.domain + '/' | |||
There was a problem hiding this comment.
This looks weird. Why is site.domain contained twice?
xaralis
reviewed
Oct 20, 2018
| @@ -37,8 +42,9 @@ | |||
| # Storage class to use. | |||
| STORAGE_CLASS = getattr(settings, 'STATICSITEMAPS_STORAGE', 'django.core.files.storage.FileSystemStorage') | |||
|
|
|||
| # How often should the celery task be run. | |||
| CELERY_TASK_REPETITION = getattr(settings, 'STATICSITEMAPS_REFRESH_AFTER', 60) | |||
There was a problem hiding this comment.
Can we make this backwards compatible somehow instead of hard removal?
added 2 commits
October 29, 2018 20:22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.