lib: remove Failure "hd" exceptions #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwintorok
reviewed
Nov 16, 2023
robhoes
approved these changes
Nov 16, 2023
lindig
approved these changes
Nov 16, 2023
Instead raise the semantically correct No_RRA_available. There's one last List.hd in the code, but it's correctly guarded so it cannot ever be used with an empty list. Signed-off-by: Pau Ruiz Safont <[email protected]>
psafont
force-pushed
the
get-out-of-my
branch
from
e85c2c5
to
03a3588
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead raise the semantically correct No_RRA_available.
There's one last List.hd in the code, but it's correctly guarded so it cannot ever be used with an empty list.