[RGen] Do not pass the root binding context around. #21945

mandel-macaque · 2025-01-11T20:05:16Z

There is no need to pass the root binding around to be able to generate the Library.g.cs. What we can do is change the code to have to diff incremental code provides.

A provider that will detect code changes.
A provider that will detect changes that required a Library.g.cs change.

To achieve the above what we do is to add the library information when we detect code changes. This new fields that provide the library information are then collected to trigger a new generation event.

There is no need to pass the root biding around to be able to gernerate the Library.g.cs. What we can do is change the code to have to diff incremental code provides. 1. A provider that will detect code changes. 2. A provider that will detect changes that required a Library.g.cs change. To achieve the above what we do is to add the library information when we detect code changes. This new fields that provide the library information are then collected to trigger a new generation event.

github-actions · 2025-01-11T20:09:21Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

mandel-macaque · 2025-01-12T01:13:47Z

/azp run xamarin-macios-pr

azure-pipelines · 2025-01-12T01:14:06Z

Azure Pipelines successfully started running 1 pipeline(s).

Copilot reviewed 5 out of 14 changed files in this pull request and generated no comments.

Files not reviewed (9)

src/rgen/Microsoft.Macios.Generator/Emitters/EnumEmitter.cs: Evaluated as low risk
src/rgen/Microsoft.Macios.Generator/Context/BindingContext.cs: Evaluated as low risk
tests/rgen/Microsoft.Macios.Generator.Tests/DataModel/EnumMemberCodeChangesTests.cs: Evaluated as low risk
tests/rgen/Microsoft.Macios.Generator.Tests/DataModel/EnumMembersEqualityComparerTests.cs: Evaluated as low risk
tests/rgen/Microsoft.Macios.Generator.Tests/DataModel/CodeChangesEqualityComparerTests.cs: Evaluated as low risk
tests/rgen/Microsoft.Macios.Generator.Tests/DataModel/CodeChangesComparerTests.cs: Evaluated as low risk
tests/rgen/Microsoft.Macios.Generator.Tests/SmartEnum/SmartEnumDiagnosticsTests.cs: Evaluated as low risk
tests/rgen/Microsoft.Macios.Generator.Tests/Context/RootBindingContextTests.cs: Evaluated as low risk
src/rgen/Microsoft.Macios.Generator/DataModel/EnumMember.cs: Evaluated as low risk

Comments suppressed due to low confidence (3)

src/rgen/Microsoft.Macios.Generator/BindingSourceGeneratorGenerator.cs:74

[nitpick] The variable name 'RootBindingContext' is ambiguous and inconsistent with its usage. It should be renamed to 'bindingContext' for clarity.

static (RootBindingContext RootBindingContext, CodeChanges Changes, bool BindingAttributeFound) GetChangesForSourceGen (GeneratorSyntaxContext context)

src/rgen/Microsoft.Macios.Generator/BindingSourceGeneratorGenerator.cs:148

The 'RootBindingContext' is being accessed from 'libraryChanges' but is not used consistently. Ensure that the context is used correctly and consistently throughout the code.

var rootBindingContext = libraryChanges [0].RootBindingContext;

src/rgen/Microsoft.Macios.Generator/DataModel/CodeChanges.cs:311

Ensure that the Skip method is comprehensive enough to handle all potential cases that might need to be skipped.

if (Skip (enumValueDeclaration, context.SemanticModel))

We cannot use Export because we need to be ablet to pass the library name to generate the property field correctly. This change moves from using Export<Field> to Field<Property> which allows to mark a property as a field AND will allow use to add the library name. This change + the one in PR #21945 improves the way the Library.g.cs file is generated.

…amarin/xamarin-macios into dev/mandel/keep-track-libs-code-change

vs-mobiletools-engineering-service2 · 2025-01-13T12:58:27Z

✅ [PR Build] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 71ef2b387ad86599f86b2dede2546127d4dfe6d7 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-13T13:09:50Z

✅ [PR Build] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 71ef2b387ad86599f86b2dede2546127d4dfe6d7 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-13T13:31:38Z

✅ API diff for current PR / commit

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

❗ API diff vs stable (Breaking changes)

.NET ( ❗ Breaking changes ❗ )

iOS: vsdrops gist ( ❗ Breaking changes ❗ )
tvOS: vsdrops gist ( ❗ Breaking changes ❗ )
MacCatalyst: vsdrops gist ( ❗ Breaking changes ❗ )
macOS: vsdrops gist ( ❗ Breaking changes ❗ )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 71ef2b387ad86599f86b2dede2546127d4dfe6d7 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-13T13:34:05Z

✅ [PR Build] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 71ef2b387ad86599f86b2dede2546127d4dfe6d7 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-13T13:44:34Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 71ef2b387ad86599f86b2dede2546127d4dfe6d7 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-13T13:46:51Z

💻 [PR Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 71ef2b387ad86599f86b2dede2546127d4dfe6d7 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-13T13:48:20Z

💻 [PR Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 71ef2b387ad86599f86b2dede2546127d4dfe6d7 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-13T13:48:54Z

💻 [PR Build] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 71ef2b387ad86599f86b2dede2546127d4dfe6d7 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-13T13:49:49Z

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 71ef2b387ad86599f86b2dede2546127d4dfe6d7 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-13T17:17:11Z

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

1 tests crashed, 0 tests failed, 108 tests passed.

Failures

❌ cecil tests

🔥 Failed catastrophically on VSTS: test results - cecil (no summary found).

Html Report (VSDrops) Download

Successes

✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 40 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 10 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 10 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 71ef2b387ad86599f86b2dede2546127d4dfe6d7 [PR build]

mandel-macaque · 2025-01-13T17:54:17Z

Cecil failures are due to bot issues. Unrelated with the PR.

We cannot use Export because we need to be ablet to pass the library name to generate the property field correctly. This change moves from using Export<Field> to Field<Property> which allows to mark a property as a field AND will allow use to add the library name. This change + the one in PR #21945 improves the way the Library.g.cs file is generated.

We cannot use Export because we need to be ablet to pass the library name to generate the property field correctly. This change moves from using Export<Field> to Field<Property> which allows to mark a property as a field AND will allow use to add the library name. This change + the one in PR #21945 improves the way the Library.g.cs file is generated. --------- Co-authored-by: GitHub Actions Autoformatter <[email protected]>

We cannot use Export because we need to be ablet to pass the library name to generate the property field correctly. This change moves from using Export<Field> to Field<Property> which allows to mark a property as a field AND will allow use to add the library name. This change + the one in PR #21945 improves the way the Library.g.cs file is generated.

mandel-macaque and others added 2 commits January 11, 2025 14:40

Auto-format source code

0a29a36

This comment has been minimized.

Sign in to view

mandel-macaque requested a review from Copilot January 12, 2025 01:21

Copilot AI reviewed Jan 12, 2025

View reviewed changes

mandel-macaque added 2 commits January 12, 2025 13:03

Do not fail if we cannot find a PR.

58e7d58

Merge branch 'dev/mandel/keep-track-libs-code-change' of github.com:x…

f351e3f

…amarin/xamarin-macios into dev/mandel/keep-track-libs-code-change

This comment has been minimized.

Sign in to view

dalexsoto approved these changes Jan 13, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

mandel-macaque merged commit 5b2e265 into main Jan 13, 2025
46 of 48 checks passed

mandel-macaque deleted the dev/mandel/keep-track-libs-code-change branch January 13, 2025 17:54

mandel-macaque mentioned this pull request Jan 13, 2025

[RGen] Use the correct attribute for field properties. #21959

Merged

[RGen] Do not pass the root binding context around. #21945

[RGen] Do not pass the root binding context around. #21945

Conversation

mandel-macaque commented Jan 11, 2025 • edited by rolfbjarne Loading

github-actions bot commented Jan 11, 2025

⚠️ Your code has been reformatted. ⚠️

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

mandel-macaque commented Jan 12, 2025

azure-pipelines bot commented Jan 12, 2025

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jan 13, 2025

✅ [PR Build] Build passed (Detect API changes) ✅

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jan 13, 2025

✅ [PR Build] Build passed (Build packages) ✅

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jan 13, 2025

✅ API diff for current PR / commit

❗ API diff vs stable (Breaking changes)

ℹ️ Generator diff

vs-mobiletools-engineering-service2 commented Jan 13, 2025

✅ [PR Build] Build passed (Build macOS tests) ✅

vs-mobiletools-engineering-service2 commented Jan 13, 2025

💻 [CI Build] Windows Integration Tests passed 💻

vs-mobiletools-engineering-service2 commented Jan 13, 2025

💻 [PR Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

vs-mobiletools-engineering-service2 commented Jan 13, 2025

💻 [PR Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

vs-mobiletools-engineering-service2 commented Jan 13, 2025

💻 [PR Build] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

vs-mobiletools-engineering-service2 commented Jan 13, 2025

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jan 13, 2025

🔥 [CI Build] Test results 🔥

Test results

Failures

❌ cecil tests

Successes

mandel-macaque commented Jan 13, 2025

mandel-macaque commented Jan 11, 2025 •

edited by rolfbjarne

Loading