-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for v8.3 ida pro plugin #162
base: master
Are you sure you want to change the base?
Conversation
22bc7eb
to
4038fa9
Compare
I simplified this PR further I removed x86 support for the IDA plugin. As starting 7.0 IDA has shifted to native 64-bit. Also on the latest 8.3 SDK I did not see support for x86. I removed the overcomplicated compilation steps which involved QT . I utilized the |
4038fa9
to
50c9efa
Compare
I am not really sure what |
50c9efa
to
91d59ea
Compare
Didn't forget about this, just been busy... |
Re: I expect it will fail the same way if you run the test in a different debugger, if so you can just ignore it. |
I made some minor changes and it looks like GitHub Actions is now happy. We could merge it as-is already, but are you sure everything is working? It seems like the IDA server executable might not work correctly in this configuration, but I didn't test yet... What were the rough steps you took to get this working and was it with the local debugger or the remote one? |
To be honest I have limited knowledge of IDA and reversing. I only tested it on a binary that has a debug protection by loading it on IDA and pressing debug. |
@@ -102,7 +104,7 @@ static bool SetDebugPrivileges() | |||
} | |||
|
|||
//callback for various debug events | |||
static int idaapi debug_mainloop(void *user_data, int notif_code, va_list va) | |||
static ssize_t idaapi debug_mainloop(void *user_data, int notif_code, va_list va) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lines 204-214 will disable loading ScyllaHide for local debuggers on x64 binaries. I think this is a significant issue and it may be a good idea to investigate why this condition was needed in the first place.
The latest build does not seem to work. HookLibraryx64.dll: not IDA DLL file |
#97
#22
I need to focus on the x86 implementation for the
ScyllaHideIDAProPlugin
, including compiling its documentation. Where is the appropriate place to incorporate this documentation? Additionally, I am not a C++ developer; I'm improvising as I go. Therefore, I welcome any suggestions or revisions necessary for this contribution to be accepted.I used this this QT version https://hex-rays.com/blog/ida-8-3-qt-5-15-2-sources-build-scripts/