Improve sidebar accordion #409
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardodiasc
approved these changes
Jul 9, 2019
There was a problem hiding this comment.
This looks very good! I tested locally on Storybook and works as expected! Well done @Moharu 🎉
Just left a suggestion to change let for const. Unless I missed the reason of that choice. Everything else looks great to me.
|
|
||
| componentDidMount = () => { | ||
| if (!this.state.isControlled) { | ||
| let { children } = this.props |
There was a problem hiding this comment.
Maybe this should be const instead?
| componentDidMount = () => { | ||
| if (!this.state.isControlled) { | ||
| let { children } = this.props | ||
| let childrenCount = React.Children.count(children) |
There was a problem hiding this comment.
This also can be const
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Type: Dev Improvements
Creates the component mentioned in https://github.com/x-team/xp/issues/1927
Description
Creates a dedicated Accordion UI Component that holds all knowledge about its
GenericCollapsiblechildren, abstracting all necessary toggle controls.Checklist
Before submitting a pull request, please make sure the following is done:
In RevieworIn Progressdepending on its status)npm run lint)npm run flow)npm run jest).stories.jsfile) is changed or added accordingly to reflect any new or updated use cases or variants usageSteps to Test or Reproduce
Check the multiple cases for
GenericCollapsibleAccordionin Storybook.Impacted Areas in Application
GenericCollapsibleAccordion