Fix capitalisation and punctuation in report #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joko3ono
requested changes
Sep 27, 2024
public/js/hit.js
Outdated
|
|
||
| if (this.props.showQueryCrumbs && this.props.showHitCrumbs) { | ||
| // Multiper queries, multiple hits | ||
| meta = `hit ${this.props.hit.number} of query ${this.props.query.number}, ` + meta; | ||
| meta = `hit ${this.props.hit.number} of query ${this.props.query.number}. ` + meta; |
There was a problem hiding this comment.
@3lviend let's make string concatenation consistent,
'hit ${this.props.hit.number} of query ${this.props.query.number}. ' + meta;
to
'hit ${this.props.hit.number} of query ${this.props.query.number}. ${meta}';
public/js/query.js
Outdated
Comment on lines
48
to
49
| var length = `length: ${this.queryLength().toLocaleString()}`; | ||
| var meta = length.charAt(0).toUpperCase() + length.slice(1); |
There was a problem hiding this comment.
is chartAt(0) is l char in above assignment?
var meta = 'Length: ${this.queryLength().toLocaleString()}'
should be fixed, right?
or did I miss something?
There was a problem hiding this comment.
Yes, that's right, just make it simpler with length -> Length. I'll update it 🚀
I thought before, we need dynamic code, without live updates to Length or anything, so I made it like now, so that later whatever the sentence is will always be capitalized.
tadast
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Capitalisation and punctuation in report
Result:
