refactor(router): redesign JWK authentication logic #1498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Router image scan passed✅ No security vulnerabilities found in image: |
Noroth
commented
Jan 10, 2025
Comment on lines
+408
to
+411
| type HeaderSource struct { | ||
| Type string `yaml:"type"` | ||
| Name string `yaml:"name"` | ||
| ValuePrefix string `yaml:"value_prefix"` | ||
| } |
There was a problem hiding this comment.
The code allows to specify multiple HeaderSources with the same name and a different value prefix. Maybe we could also make this a list of value prefixes if someone decides that they want to have multiple options for prefixes
Noroth
force-pushed
the
ludwig/eng-6230-redesign-jwk-authentication-logic
branch
from
cc46adb to
eadd615
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Checklist