Improve slack messaging #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibackup status does not yet include this info information not sent to slack yet failing main test due to slack issue
…ing for messages to be sent.
Send slack message when num irods connections increases. Still need to implement decrementing and debouncing.
Fix real slack implementation to match slacker interfaces
Break it in to Replaced and Skipped, and slack that info. Still need to report on recently uploaded size, not total size.
Output in `ibackup status` Still need to send this info to slack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have commented out a randomly failing test, so linting fails, but we can only fix that in the next PR once this PR is merged.