Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new set status filter flags #54

Merged
merged 8 commits into from
Nov 22, 2023
Merged

Add new set status filter flags #54

merged 8 commits into from
Nov 22, 2023

Conversation

sb10
Copy link
Contributor

@sb10 sb10 commented Nov 20, 2023

No description provided.

@sb10 sb10 requested a review from mjkw31 November 20, 2023 11:22
@sb10 sb10 marked this pull request as draft November 20, 2023 11:24
mjkw31
mjkw31 reviewed Nov 20, 2023
View reviewed changes
cmd/status.go Outdated Show resolved Hide resolved
mjkw31
mjkw31 reviewed Nov 20, 2023
View reviewed changes
cmd/status.go Show resolved Hide resolved
mjkw31
mjkw31 reviewed Nov 20, 2023
View reviewed changes
Copy link
Contributor

@mjkw31 mjkw31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there tests already in place for the status filter?

@sb10 sb10 marked this pull request as ready for review November 20, 2023 15:02
sb10
sb10 commented Nov 20, 2023
View reviewed changes
Copy link
Contributor Author

@sb10 sb10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests added

mjkw31
mjkw31 approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@mjkw31 mjkw31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sb10 sb10 merged commit f8d46c6 into develop Nov 22, 2023
4 checks passed
@sb10 sb10 deleted the statusflags branch November 22, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjkw31 mjkw31 mjkw31 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sb10 @mjkw31