Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Fix write out type conversion #133

Merged
merged 1 commit into from
Mar 21, 2022
Merged

WIP: Fix write out type conversion #133

merged 1 commit into from
Mar 21, 2022

Conversation

e-lo
Copy link
Collaborator

@e-lo e-lo commented Mar 17, 2022

Addresses #132

*** hasn't been tested yet, but I think will work ***

@e-lo e-lo added the fix Something isn't working/bug fix label Mar 17, 2022
@e-lo e-lo requested a review from DavidOry March 17, 2022 15:53
@e-lo e-lo changed the base branch from master to develop March 21, 2022 17:12
DavidOry
DavidOry approved these changes Mar 21, 2022
View reviewed changes
Copy link
Member

@DavidOry DavidOry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DavidOry DavidOry merged commit 554ce0b into develop Mar 21, 2022
@DavidOry DavidOry deleted the fix-write-out-type-conversion branch March 21, 2022 17:18
@e-lo e-lo restored the fix-write-out-type-conversion branch April 1, 2022 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidOry DavidOry DavidOry approved these changes

Assignees
No one assigned
Labels
fix Something isn't working/bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@e-lo @DavidOry