[Do Not Merge] Documentation, Small Redesigns, Migration to Gradle, & More #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlbertSnows
commented
Dec 15, 2023
| Pair<List<S>, List<F>> successesAndFailures = results.stream().collect(split()); | ||
| if(successesAndFailures.right.isEmpty()) { | ||
| return Result.success(successesAndFailures.left); | ||
| if(successesAndFailures.right().isEmpty()) { |
There was a problem hiding this comment.
stuff like this is from converting to a record
AlbertSnows
commented
Dec 15, 2023
|
|
||
| public final L left; | ||
| public final R right; | ||
| public record Pair<L, R>(L left, R right) { |
There was a problem hiding this comment.
If it was converted to a record, it should be because the only fields were public final, and thus shouldn't cause any issues (assuming property access was changed from A.B to A.B())
|
I have briefly reviewed the PR. The changes are largely documentation or QoL in nature, with a few different renames, changes, converts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge this PR, as it contains too many changes to review at once. It does, however, pass all tests and builds. As such, this PR should not introduce any breaking changes.
Why does this PR exists?
Since this repo is largely educational, this PR exists to bring more attention to some redesign and documentation considerations that more formally align with java standards. At the whims of the repo owner, any part of this PR can be integrated into the main repo. Otherwise, if this repo is to remain untouched, my hope is that this PR will draw others to look at the contributions I've added which will, hopefully, make some concepts and design choices a bit clearer.
Additionally, there are some parts of the dev environment that either don't work well anymore, have depreciated components, or are otherwise out of date. This PR also attempts to fix these. As for gradle, I just have less headaches using it, so I decided to migrate the repo over. It's purely a personal preference.
Finally, if the repo owner has any requests, critiques, or considerations I would be happy to address them. I made these changes of my own accord, and figured someone else might find them useful. I'm not particularly attached to any of my changes, and I view any feedback as a boon.
Thank you!