Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have not yet done test things, though ad hoc tested with teh curves provided in the tests repo
This largely derives from the attune 0.3.1 code.
I have left off saving, largely so that I could ignore fields we don't need for our internal representation (e.g. polarization, comment, etc)
The old version just passed
**kwargs
and didsetattr
on extra kwargs. This currently drops them on the floor.I think there may be some finer details that possibly are represented in the file, but are not handled:
Additionally, it currently uses string integer values for motor names, which actually appears to be consistent with attune 0.3.1 behavior, but is negotiable (probably would just be providing a list to the
from_topas3
method).Perhaps we would want to include a handy reference lists for the names of the Wright group OPAs.