Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] plot_colorbar soft deprecation #1173

Draft
wants to merge 26 commits into
base: master
Choose a base branch
from
Draft

[WIP] plot_colorbar soft deprecation #1173

wants to merge 26 commits into from

Conversation

ddkohler
Copy link
Contributor

@ddkohler ddkohler commented Mar 22, 2024 •
edited
Loading

Changes

  • deprecation warning for plot_colorbar. all features of this function are directly supported in matplotlib.pyplot.colorbar (or the matplotlib's Figure.colorbar method)
  • replaced all internal usage of plot_colorbar
  • refactored datasets module--this refactor was done just to make sphinx tests happy. resolves pytest: build_sphinx failing when examples are modified #1174
  • new example highlighting usage of colorbar usage with different norms

Checklist

  • added tests, if applicable
  • updated documentation, if applicable
  • updated CHANGELOG.md
  • tests pass

@ddkohler
soft deprecate plot_colorbar
69ad6ea 
remove from examples, docs
@ddkohler ddkohler changed the title [WIP] Plan plot colorbar deprecation [WIP] plot_colorbar soft deprecation Mar 22, 2024
@ddkohler ddkohler mentioned this pull request Mar 23, 2024
Open
ddkohler and others added 8 commits March 23, 2024 11:07
@ddkohler
Update split.py
31fa0bd
@ddkohler
re-implement module reset (#1175)
fdf358c 
* re-implement module reset

* Update split.py

* Update split.py

* Update conf.py

* Update split.py

* Update fringes_transform.py

* Update __init__.py

* Update fringes_transform.py

* Revert "Update fringes_transform.py"

This reverts commit 7911367.

* node 20
@ddkohler
new example for norms, cbar
ddf2db8
@ddkohler
Merge branch 'master' into plan-plot_colorbar-deprecation
c75a0d6
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
39c36bf 
for more information, see https://pre-commit.ci
@ddkohler
abandon using datasets as module
1622cd9
@ddkohler
try new load method
5cd0cf5
@ddkohler
datasets us SimpleNamespace
0be6b2e 
still trying to fix sphinx build test
@ddkohler
Copy link
Contributor Author

ddkohler commented Apr 1, 2024

finally found a way to make sphinx test happy with datasets! 🥇

github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 1, 2024
View reviewed changes
WrightTools/artists/_helpers.py Fixed Show fixed Hide fixed
WrightTools/artists/_helpers.py Fixed Show fixed Hide fixed
examples/norms.py Fixed Show fixed Hide fixed
docs/conf.py Fixed Show fixed Hide fixed
examples/norms.py Fixed Show fixed Hide fixed
examples/norms.py Fixed Show fixed Hide fixed
examples/norms.py Fixed Show fixed Hide fixed
github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 1, 2024
View reviewed changes
examples/norms.py Dismissed Show dismissed Hide dismissed
@ddkohler
Copy link
Contributor Author

ddkohler commented Apr 1, 2024

other functions to consider for deprecation:
set_ax_labels
pcolor_helper (already has deprecation warning)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@untzag untzag Awaiting requested review from untzag untzag will be requested when the pull request is marked ready for review untzag is a code owner

@ksunden ksunden Awaiting requested review from ksunden ksunden will be requested when the pull request is marked ready for review ksunden is a code owner

@darienmorrow darienmorrow Awaiting requested review from darienmorrow darienmorrow will be requested when the pull request is marked ready for review darienmorrow is a code owner

@kameyer226 kameyer226 Awaiting requested review from kameyer226 kameyer226 will be requested when the pull request is marked ready for review kameyer226 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pytest: build_sphinx failing when examples are modified
1 participant
@ddkohler