artists.quicknD bug fix
#1160
Merged
artists.quicknD bug fix
#1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…group/WrightTools into refactor-artists-quicknD
pytest 8.0.0 works locally for me...
for some reason it hates my use of * notation...
Path.__enter__ will be deprecated in python 3.13
trim whitespace
for more information, see https://pre-commit.ci
ddkohler
changed the title
artists.quickNd: fix issues related to channels with smaller dimensionality
ddkohler
changed the title
artists.quickNd: fix issues related to channels with smaller dimensionalityartists.quickNd refactor, bug fixes
try to make test robust to intermittent FileNotFound errors
ddkohler
requested review from
untzag,
ksunden,
darienmorrow and
kameyer226
as code owners
kameyer226
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue where collapsing unused dims on a channel did not actually work.
Additional tweaks to tests to help with passing (OSF download links are intermittently failing atm).
Please squash and merge this PR, there is a lot of commit junk here.
Changes
Checklist
updated documentation, if applicable