Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

interact2d cmap options #1073

Merged
merged 10 commits into from
Jun 17, 2022
Merged

interact2d cmap options #1073

merged 10 commits into from
Jun 17, 2022

Conversation

ddkohler
Copy link
Contributor

@ddkohler ddkohler commented Jun 9, 2022 •
edited
Loading

Changes

  • Bump versions: mpl >= 3.4, Python >=3.7

interact2D

Checklist

  • added tests, if applicable
  • updated documentation, if applicable
  • updated CHANGELOG.md
  • tests pass

@ksunden
Copy link
Member

ksunden commented Jun 16, 2022

You will actually need to get rid of py3.6 if you want to bump mpl version...

Like I said, I'm good with it, but yeah, mpl itself has removed support for 3.6

@ddkohler
Copy link
Contributor Author

Would be interesting to have TwoSlopeNorm, but I think that is the less desired than CenteredNorm for signed data.

We could introduce yet another kwarg to interact2D to make this possible...

@ddkohler ddkohler marked this pull request as ready for review June 17, 2022 16:29
@ddkohler ddkohler changed the title WIP: interact2d cmap options interact2d cmap options Jun 17, 2022
kameyer226
kameyer226 approved these changes Jun 17, 2022
View reviewed changes
Copy link
Contributor

@kameyer226 kameyer226 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@kameyer226 kameyer226 merged commit 0b07857 into master Jun 17, 2022
@kameyer226 kameyer226 deleted the interact2d-cmap branch June 17, 2022 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kameyer226 kameyer226 kameyer226 approved these changes

@untzag untzag Awaiting requested review from untzag untzag is a code owner

@ksunden ksunden Awaiting requested review from ksunden ksunden is a code owner

@darienmorrow darienmorrow Awaiting requested review from darienmorrow darienmorrow is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ddkohler @ksunden @kameyer226