feat: query composer (explorer) as a "built-in" GraphiQL plugin #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the
@graphiql/plugin-exploreras a "built-in" GraphiQL plugin.Unfortunately, I don't think this will work as-is. There are some funky issues with it.
graphiql-explorer-errors.mp4
Some of these issues might be able to be resolved via CSS adjustments, but I think ultimately we'll need to pull the source code of the plugin and include it in our codebase instead of relying on it as a 3rd party plugin.
If we take a look at the plugin, we can see that it's a thin wrapper over the GraphQL Explorer that was built for the old GraphiQL IDE that did not have a plugin system, and as such it's not making use of current things like the activity panel state, etc.
Additionally, as we we work on things like implementing Custom Scalars, image uploads, etc, the composer as-is won't know how to support those scalars, so we will need to control the source code at a more granular level anyway.
related #5