feat: implement redux #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update App.jsx to set initial state of the redux store using GET queryParams if available, and use selectors to handle state instead of local useState - register redux store - update Editor.jsx to useSelect and useDispatch to update the redux store and determine if the close drawer button should be shown - add new RenderApp component to use state from the redux store to determine how the app should render (in a drawer or standalone) - update a few tests
Merged
josephfusco
reviewed
Feb 28, 2024
josephfusco
reviewed
Feb 28, 2024
Signed-off-by: Joe Fusco <[email protected]>
…hiql-x into feat/implement-redux
|
@jasonbahl I have pushed some commits to this branch that fix #50 |
Signed-off-by: Joe Fusco <[email protected]>
|
|
|
@josephfusco your changes for the styles look good, and I removed the duplicate "docker-compose" |
Signed-off-by: Joe Fusco <[email protected]>
jasonbahl
commented
Feb 28, 2024
josephfusco
previously approved these changes
Feb 28, 2024
Signed-off-by: Joe Fusco <[email protected]>
Signed-off-by: Joe Fusco <[email protected]>
josephfusco
previously approved these changes
Feb 28, 2024
josephfusco
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@josephfusco this expands on your Dedicated Screen PR and updates the app to render as a standalone ide or within the drawer based on the screenId passed up in localized.json.
This also converts use of
useState()touseSelectanduseDispatchso that the state is lifted out of individual components and tracked in the Redux store.We should lift as much state out of components and up into the store as we can so that extensions can make use of the shared state.
Definitely need to make some styling adjustments to the standalone page as well.
related: #41