-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: register activity bar panel API #165
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilityButton access functions - update ActivityBarPlugins.jsx to read from redux instead of the pluginContext - Rename DocumentSessions to EditorGroup - refactor registry/index.js to be more clean and abstract different registries into their own "domain" - introduce activity-bar redux store (to contain state for Activity Bar Plugin Buttons and Activity Bar Utility Buttons
…ns from redux and pass it in - hook up onTogglePluginVisibility with redux - modify HelpPanel to behave with existing GraphiQL plugin "shape" - update registerPanel action - add toggleActivityPanelVisibility action - update initial state of the activityPanels - add TOGGLE_ACTIVITY_PANEL_VISIBILITY reducer - change selector panels to activityPanels
- update third-party index - split Explorer into its own components - move Explorer utils into its own file - simplify App.jsx - move Query Composer styles from main plugin into 3rd party
josephfusco
changed the title
Feat/issue 110 register activity bar panel
feat: register activity bar panel API
Jun 5, 2024
- update start scripts - update webpack entry to combine plugins, main ide and graphql-js - update paths to assets in help-panel.php and query-composer-panel.php - update use of `registerActivityBarPanel` so that the config is an object instead of a function - update activity bar reducer validation logic for registerActivityBarPanel - update logo with new svg - rename help-panel.js and query-composer-panel.js to match webpack config settings (file name for entry must match plugin name)
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces the
registerActivityBarPanel
API and refactors thehelp panel
andquery composer panel
as (built-in) 3rd party PHP plugins that make use of the API.In addition to introducing the API, this updates the build scripts (and start scripts) to build the main plugin and extending plugins by running
npm run build
ornpm run start
.