Don’t run version_compare with null

I ran into deprecation warnings where `$tag` was `null` when running these commands in preparation for the 2.9.0 release
wp-cli · Oct 25, 2023 · 362abcc · 362abcc
1 parent 6a909c2
commit 362abcc
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/.maintenance/src/Contrib_List_Command.php b/.maintenance/src/Contrib_List_Command.php
@@ -123,6 +123,9 @@ public function __invoke( $args, $assoc_args ) {
 			$milestone  = array_reduce(
 				$milestones,
 				function ( $tag, $milestone ) {
+					if ( ! $tag ) {
+						return $milestone->title;
+					}
 					return version_compare( $milestone->title, $tag, '>' ) ? $milestone->title : $tag;
 				}
 			);

diff --git a/.maintenance/src/Release_Notes_Command.php b/.maintenance/src/Release_Notes_Command.php
@@ -115,6 +115,9 @@ static function ( $latest, $milestone ) {
 		$milestone = array_reduce(
 			$milestones,
 			function ( $tag, $milestone ) {
+				if ( ! $tag ) {
+					return $milestone->title;
+				}
 				return version_compare( $milestone->title, $tag, '>' ) ? $milestone->title : $tag;
 			}
 		);