Tests/shared #3
Merged
Tests/shared #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The escape character logic was not working correctly. The logic of how a line is folded with a final escape character was flawed. Using a loop to consume forward slashes would not allow for an escaped forward slash to be folded correctly, it would append an extra character to the line. - Use if statements to check for escape characters. Only one extra character should be appended to the line, and it should be considered escaped. - Add new test cases to test the escape character logic.
fix: foldLine escape character logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this Pr we are going to fix some inconsistencies in the shared functions and adding some tests, in order to ensure proper functioning