Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node: Add Noble support over IBC #4195

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Node: Add Noble support over IBC #4195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions node/pkg/watchers/ibc/watcher.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ var (
vaa.ChainIDSeda,
vaa.ChainIDDymension,
vaa.ChainIDProvenance,
vaa.ChainIDNoble,
}

// features is the feature string to be published in the gossip heartbeat messages. It will include all chains that are actually enabled on IBC.
Expand Down
7 changes: 7 additions & 0 deletions sdk/vaa/structs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,8 @@ func (c ChainID) String() string {
return "dymension"
case ChainIDProvenance:
return "provenance"
case ChainIDNoble:
return "noble"
case ChainIDSepolia:
return "sepolia"
case ChainIDArbitrumSepolia:
Expand Down Expand Up @@ -360,6 +362,8 @@ func ChainIDFromString(s string) (ChainID, error) {
return ChainIDDymension, nil
case "provenance":
return ChainIDProvenance, nil
case "noble":
return ChainIDNoble, nil
case "sepolia":
return ChainIDSepolia, nil
case "arbitrum_sepolia":
Expand Down Expand Up @@ -431,6 +435,7 @@ func GetAllNetworkIDs() []ChainID {
ChainIDSeda,
ChainIDDymension,
ChainIDProvenance,
ChainIDNoble,
ChainIDSepolia,
ChainIDArbitrumSepolia,
ChainIDBaseSepolia,
Expand Down Expand Up @@ -546,6 +551,8 @@ const (
ChainIDDymension ChainID = 4007
// ChainIDProvenance is the ChainID of Provenance
ChainIDProvenance ChainID = 4008
// ChainIDNoble is the ChainID of Noble
ChainIDNoble ChainID = 4009
// ChainIDSepolia is the ChainID of Sepolia
ChainIDSepolia ChainID = 10002
// ChainIDArbitrumSepolia is the ChainID of Arbitrum on Sepolia
Expand Down
2 changes: 2 additions & 0 deletions sdk/vaa/structs_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ func TestChainIDFromString(t *testing.T) {
{input: "seda", output: ChainIDSeda},
{input: "dymension", output: ChainIDDymension},
{input: "provenance", output: ChainIDProvenance},
{input: "noble", output: ChainIDNoble},
{input: "sepolia", output: ChainIDSepolia},
{input: "arbitrum_sepolia", output: ChainIDArbitrumSepolia},
{input: "base_sepolia", output: ChainIDBaseSepolia},
Expand Down Expand Up @@ -139,6 +140,7 @@ func TestChainIDFromString(t *testing.T) {
{input: "Seda", output: ChainIDSeda},
{input: "Dymension", output: ChainIDDymension},
{input: "Provenance", output: ChainIDProvenance},
{input: "Noble", output: ChainIDNoble},
{input: "Sepolia", output: ChainIDSepolia},
{input: "Arbitrum_Sepolia", output: ChainIDArbitrumSepolia},
{input: "Base_Sepolia", output: ChainIDBaseSepolia},
Expand Down
Loading