Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dispatcher components #66

Merged
merged 11 commits into from
Jan 16, 2025
Merged

Add dispatcher components #66

merged 11 commits into from
Jan 16, 2025

Conversation

AgusVelez5
Copy link
Contributor

No description provided.

solanoepalacio
solanoepalacio previously approved these changes Oct 23, 2024
View reviewed changes
@nonergodic nonergodic force-pushed the dispatcher-components branch from 0cf8677 to 69ec4b2 Compare November 15, 2024 23:07
@solanoepalacio solanoepalacio dismissed their stale review November 18, 2024 12:19

Not ready to review

nonergodic
nonergodic reviewed Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@nonergodic nonergodic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving these comments primarily for documentation/feedback. About to push a commit that addresses everything here.

.gitmodules Outdated Show resolved Hide resolved
src/TransferUtils.sol Outdated Show resolved Hide resolved
src/TransferUtils.sol Outdated Show resolved Hide resolved
src/TransferUtils.sol Outdated Show resolved Hide resolved
src/dispatcherComponents/SweepTokens.sol Outdated Show resolved Hide resolved
src/dispatcherComponents/AccessControl.sol Outdated Show resolved Hide resolved
src/dispatcherComponents/AccessControl.sol Outdated Show resolved Hide resolved
src/dispatcherComponents/AccessControl.sol Outdated Show resolved Hide resolved
src/dispatcherComponents/AccessControl.sol Outdated Show resolved Hide resolved
src/dispatcherComponents/AccessControl.sol Outdated Show resolved Hide resolved
nonergodic
nonergodic reviewed Nov 19, 2024
View reviewed changes
src/TransferUtils.sol Outdated Show resolved Hide resolved
nonergodic
nonergodic previously approved these changes Nov 19, 2024
View reviewed changes
scnale
scnale previously requested changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@scnale scnale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm marking this as request changes because I'm making some adjustments but have to go away. Reach out to me if I leave this hanging for too long.

README.md Outdated Show resolved Hide resolved
@scnale scnale dismissed their stale review November 21, 2024 15:02

I finished with my changes

nonergodic
nonergodic approved these changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@nonergodic nonergodic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high time to pull this in. I'll make a few more changes later.

@nonergodic nonergodic merged commit af97781 into wormhole-foundation:main Jan 16, 2025
1 check passed
@AgusVelez5 AgusVelez5 deleted the dispatcher-components branch January 16, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nonergodic nonergodic nonergodic approved these changes

@scnale scnale scnale left review comments

@solanoepalacio solanoepalacio solanoepalacio left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AgusVelez5 @solanoepalacio @scnale @nonergodic