Add Noble support #759
Merged
Add Noble support #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnletey
reviewed
Dec 17, 2024
There was a problem hiding this comment.
Looks good @bruce-riley. What about getting Noble's testnet added as well?
Here is the SVG for the icon:
<svg width="600" height="600" viewBox="0 0 600 600" fill="none" xmlns="http://www.w3.org/2000/svg">
<rect width="600" height="600" rx="300" fill="#020418"/>
<path d="M442.929 338.488C442.939 352.28 440.279 365.732 435.009 378.465C429.729 391.218 422.11 402.613 412.375 412.357C402.611 422.111 391.206 429.72 378.472 434.99C365.757 440.251 352.334 442.93 338.581 442.93H338.503H338.484H338.076C316.044 442.93 294.176 435.747 276.454 422.694C258.614 409.552 245.21 390.646 238.542 368.818C235.553 358.977 234.039 348.795 234.058 338.527V261.513C234.068 254.176 236.921 247.285 242.114 242.093C247.307 236.91 254.198 234.056 261.516 234.047C268.844 234.066 275.735 236.939 280.918 242.112C286.091 247.295 288.955 254.186 288.974 261.504V338.498C288.984 351.717 294.147 364.159 303.523 373.506C310.473 380.436 319.237 385.104 328.865 386.996C338.484 388.908 348.374 387.928 357.449 384.172C366.514 380.416 374.192 374.127 379.656 365.965C385.13 357.812 388.032 348.32 388.052 338.488V184.529C388.052 180.909 388.751 177.366 390.139 174.018C391.517 170.679 393.516 167.68 396.088 165.118C398.651 162.565 401.64 160.556 404.989 159.168C411.676 156.412 419.295 156.402 425.992 159.168C429.341 160.556 432.33 162.565 434.892 165.118C437.455 167.68 439.454 170.679 440.842 174.018C442.23 177.366 442.929 180.909 442.929 184.529V338.488ZM226.517 226.486C217.16 235.842 211.997 248.285 211.987 261.504V415.473C211.987 422.8 209.134 429.691 203.941 434.884C193.575 445.269 175.483 445.269 165.108 434.884C159.925 429.691 157.071 422.8 157.071 415.473V261.513C157.091 236.483 166.107 212.267 182.462 193.322C198.826 174.377 221.46 161.934 246.22 158.266C251.315 157.509 256.43 157.13 261.526 157.13C281.2 157.13 300.611 162.701 317.403 173.329C325.332 178.347 332.486 184.374 338.717 191.206C338.775 191.148 338.814 191.08 338.872 191.022L339.018 191.575C349.257 202.902 356.983 216.412 361.477 231.222L361.904 232.63C364.631 242.025 366.01 251.74 366.019 261.504V338.488C366.019 343.933 364.418 349.203 361.39 353.726C358.361 358.249 354.11 361.743 349.083 363.839C345.812 365.198 342.356 365.838 338.872 365.877V365.926C338.736 365.926 338.61 365.887 338.474 365.887C336.727 365.887 334.97 365.77 333.223 365.421C332.214 365.227 331.234 364.916 330.263 364.606V364.47C329.603 364.256 328.924 364.15 328.283 363.878C323.255 361.781 319.004 358.287 315.976 353.765C312.948 349.232 311.346 343.962 311.346 338.527V268.802H311.327V261.494C311.307 254.923 310.026 248.527 307.512 242.491C304.989 236.444 301.349 231.028 296.7 226.399C292.051 221.779 286.616 218.178 280.54 215.684C274.474 213.189 268.029 211.85 261.526 211.967C248.306 211.976 235.873 217.14 226.517 226.486ZM450.47 149.531C441.114 140.184 428.69 135.031 415.481 135.011H415.461C402.251 135.05 389.838 140.213 380.501 149.56C371.183 158.906 366.039 171.32 366.019 184.529V190.09C352.101 169.757 332.476 153.84 309.395 144.406C280.637 132.682 248.666 131.876 219.334 142.222C194.546 151.016 173.416 167.01 158.236 188.479C143.056 209.958 135.019 235.211 135 261.504V415.473C135 428.701 140.154 441.134 149.51 450.49C158.857 459.846 171.3 465 184.529 465C197.758 465 210.191 459.846 219.548 450.49C228.904 441.134 234.058 428.701 234.058 415.473V409.95C247.986 430.274 267.592 446.191 290.673 455.605C319.412 467.329 351.373 468.096 380.695 457.779C405.474 448.996 426.584 432.991 441.774 411.522C456.944 390.044 464.981 364.81 465 338.527V184.519C464.981 171.31 459.817 158.887 450.47 149.531Z" fill="url(#paint0_linear_6_202)"/>
<defs>
<linearGradient id="paint0_linear_6_202" x1="120.441" y1="462.562" x2="463.109" y2="95.4635" gradientUnits="userSpaceOnUse">
<stop offset="0.05" stop-color="white"/>
<stop offset="0.38" stop-color="#A7B3FF"/>
<stop offset="1" stop-color="#74A4FF"/>
</linearGradient>
</defs>
</svg>
bruce-riley
force-pushed
the
add_noble_support
branch
from
085c916 to
67e1446
Compare
bruce-riley
force-pushed
the
add_noble_support
branch
from
67e1446 to
0f18834
Compare
bruce-riley
requested review from
nik-suri,
panoel,
evan-gray and
johnletey
and removed request for
johnletey
bruce-riley
force-pushed
the
add_noble_support
branch
from
12f1bb5 to
56cc5b2
Compare
|
@johnletey is "grand-1" the IBC chain ID for Noble testnet? |
|
That's correct @bruce-riley |
nik-suri
approved these changes
Dec 17, 2024
johnletey
approved these changes
Dec 18, 2024
|
@johnletey testnet generally uses the same chain ID as mainnet. The only time they are different is when we have to deploy a second (sometimes parallel) testnet. |
bingyuyap
approved these changes
Dec 18, 2024
panoel
approved these changes
Dec 18, 2024
evan-gray
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The companion guardian PR is here.