Skip to content

Commit

Permalink
Merge pull request #2 from workplacearcade/porter-adjustments
Browse files Browse the repository at this point in the history
Porter adjustments
  • Loading branch information
diiq authored Jan 27, 2023
2 parents 34c0b6c + 0bb57ee commit 24b1e08
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
4 changes: 4 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
Porter and K8s are unable to run prerender as-is; chrome cannot be started outside the context of a shell. This fork of prerender makes a one-line change to enable prerender to manage chrome in K8s.

See https://arcade-inc.slack.com/archives/C02K09F3ZT5/p1674741952181659

Prerender
===========================

Expand Down
2 changes: 1 addition & 1 deletion lib/browsers/chrome.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ chrome.spawn = function (options) {
'--disable-gpu',
'--remote-debugging-port=' + this.options.browserDebuggingPort,
'--hide-scrollbars',
]);
], {shell: true});

resolve();
});
Expand Down

0 comments on commit 24b1e08

Please sign in to comment.