Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error handling in node-sso-example #58

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

rwtombaugh
Copy link
Contributor

Includes the following updates:

  • Improve node-sso-example app callback route to distinguish between errors provided in the redirect and those from exchanging the code for a profile and token.
  • Update the Server is running... messages of all apps to correctly state http and not https
  • update the node-sso-example app to use the organizationId=org_test_idp by default

@@ -16,7 +16,7 @@ app.use(

const workos = new WorkOS(process.env.WORKOS_API_KEY)
const clientID = process.env.WORKOS_CLIENT_ID
const organizationID = ''
const organizationID = 'org_test_idp'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice touch

Copy link
Contributor

@amygdalama amygdalama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@rwtombaugh rwtombaugh merged commit 9b619d4 into main Feb 22, 2024
3 checks passed
@rwtombaugh rwtombaugh deleted the randall/fix-node-sso-example-errors branch February 22, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants