Better cookie error handling #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…show the same results
PaulAsjes
changed the title
PaulAsjes
changed the title
mthadley
approved these changes
Dec 27, 2024
| 'You must provide a valid cookie password that is at least 32 characters in the environment variables.', | ||
| ); | ||
|
|
||
| jest.replaceProperty(envVariables, 'WORKOS_COOKIE_PASSWORD', originalWorkosCookiePassword); |
There was a problem hiding this comment.
If you set restoreMocks to true in the Jest config then properties like this will automatically be restored between tests without a need to keep track of original values like this. I think it's a good default behavior to go with.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #112
Throws if the cookie password is missing or if it's too short.
Also adds a test for the
onSuccesshandler, which was merged prior to when we had tests for this repo.