-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Woo] Allow signing in to WPCom black-flagged websites using site credentials #154
Conversation
In Woo, XMLRPC discovery is not used anymore, so the code removed here wasn't used
0f2741d
to
7c87215
Compare
default void gotConnectSiteInfo(@NonNull ConnectSiteInfoResult result) { | ||
gotConnectedSiteInfo(result.getUrl(), result.getUrlAfterRedirects(), result.getHasJetpack()); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With these default implementations, we can avoid making this a breaking change for the client apps, for now, the apps will keep overriding the old version gotConnectedSiteInfo
, while for WCAndroid, we will soon migrate to the new one gotConnectSiteInfo
that passes the new model ConnectSiteInfoResult
which would allow us to know if the site is suspended.
Closes: woocommerce/woocommerce-android#12779
Depends on wordpress-mobile/WordPress-FluxC-Android#3107
This PR updates the login flow for Woo to allow signing in to WordPress.com black-flagged websites, those websites will be treated as not having Jetpack, and will then be directed to the site credentials login flow.
Testing
For testing, please check woocommerce/woocommerce-android#12780