[Woo] Allow signing in to WPCom black-flagged websites using site credentials #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Woo, XMLRPC discovery is not used anymore, so the code removed here wasn't used
hichamboushaba
force-pushed
the
issue/12779-black-flagged-websites-woo
branch
from
0f2741d
to
7c87215
Compare
hichamboushaba
commented
Oct 14, 2024
Comment on lines
+64
to
+67
| default void gotConnectSiteInfo(@NonNull ConnectSiteInfoResult result) { | ||
| gotConnectedSiteInfo(result.getUrl(), result.getUrlAfterRedirects(), result.getHasJetpack()); | ||
| } | ||
|
|
There was a problem hiding this comment.
With these default implementations, we can avoid making this a breaking change for the client apps, for now, the apps will keep overriding the old version gotConnectedSiteInfo, while for WCAndroid, we will soon migrate to the new one gotConnectSiteInfo that passes the new model ConnectSiteInfoResult which would allow us to know if the site is suspended.
4 tasks
JorgeMucientes
approved these changes
Oct 16, 2024
WordPressLoginFlow/src/main/java/org/wordpress/android/login/LoginSiteAddressFragment.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: woocommerce/woocommerce-android#12779
Depends on wordpress-mobile/WordPress-FluxC-Android#3107
This PR updates the login flow for Woo to allow signing in to WordPress.com black-flagged websites, those websites will be treated as not having Jetpack, and will then be directed to the site credentials login flow.
Testing
For testing, please check woocommerce/woocommerce-android#12780