[Dependency Analysis] Remove Unused Dependencies #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release Notes: https://github.com/JetBrains/kotlin/releases/tag/v1.9.25 ------------------------------------------------------------------------ This update isn't that necessary, but should be considered anyway as it will do the following: - Align this library, to that Kotlin version, which is already used by most of this library's clients and libraries. - Unblock the usage of the dependency analysis Gradle plugin for this project on newer versions (1.33.0). - Prepares this project for the Kotlin 2+ major update. ------------------------------------------------------------------------ FYI: Without updating Kotlin to '1.9.25', when updating Dependency Analysis to '1.33.0', and then running './gradlew assembleDebug', it produces the below build failure: FAILURE: Build failed with an exception. * What went wrong: Could not initialize class org.jetbrains.kotlin.gradle.report. ConfigureReporingKt > Exception java.lang.IncompatibleClassChangeError: Method 'org.jetbrains.kotlin.build.report.metrics.BuildTime[] org.jetbrains.kotlin.build.report.metrics.BuildTime.values()' must be InterfaceMethodref constant [in thread "Daemon worker Thread 2"]
Release Notes: https://github.com/autonomousapps/ dependency-analysis-gradle-plugin/blob/main/CHANGELOG.md#version-1330
Removing the 'androidx.core.ktx' dependency wasn't enough by itself as the dependency graph got updated with dependencies pointing to other versions. Adding the transient 'androidx.core:core' dependency was actually necessary in order to keep the dependency graph unaffected. ------------------------------------------------------------------------ This replacement was suggested by the dependency analysis report, see below: Advice for :WordPressLoginFlow Unused dependencies which should be removed: implementation 'androidx.core:core-ktx:1.12.0' ... These transitive dependencies should be declared directly: api 'androidx.core:core:1.12.0' ...
This dependency is completely unused. FYI: It got introduced as part of this (f50df67) commit, which updated the support libs to a newer version (not sure why). ------------------------------------------------------------------------ This removal was suggested by the dependency analysis report, see below: Advice for :WordPressLoginFlow Unused dependencies which should be removed: implementation 'androidx.gridlayout:gridlayout:1.0.0' ...
This dependency is completely unused. FYI: It got introduced as part of this (d3dc350) commit, a part of the AndroidX migration (not sure why). ------------------------------------------------------------------------ This removal was suggested by the dependency analysis report, see below: Advice for :WordPressLoginFlow Unused dependencies which should be removed: implementation 'androidx.legacy:legacy-support-v13:1.0.0' ...
This dependency is completely unused. FYI: It got introduced as part of this (f50df67 and then d3dc350 and) commits, first an update to the support libs to a newer version and then as part of the AndroidX migration (not sure why). ------------------------------------------------------------------------ This removal was suggested by the dependency analysis report, see below: Advice for :WordPressLoginFlow Unused dependencies which should be removed: implementation 'androidx.media:media:1.2.1' ...
Since the 'minSdkVersion' of this project is currently on '24' this vector drawables backward compatibility solution is no longer required. As such, this config is unnecessary and can be now safely removed. For more info see: - Vector drawables backward compatibility solution (Doc): https://developer.android.com/develop/ui/views/graphics/ vector-drawable-resources#vector-drawables-backward-solution - androidx.vectordrawable.graphics.drawable.VectorDrawableCompat (Doc): https://developer.android.com/reference/androidx/vectordrawable/ graphics/drawable/VectorDrawableCompat
This dependency is completely unused. FYI: It got introduced as part of this (f50df67) commit, which updated the support libs to a newer version (not sure why). ------------------------------------------------------------------------ This removal was suggested by the dependency analysis report, see below: Advice for :WordPressLoginFlow Unused dependencies which should be removed: implementation 'androidx.vectordrawable:vectordrawable-animated:1.1.0'
wzieba
approved these changes
Aug 14, 2024
wzieba
pushed a commit
that referenced
this pull request
Oct 15, 2024
…endencies [Dependency Analysis] Remove Unused Dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Project Thread: paaHJt-6YV-p2
Description
Based on the
unusedrelated advises generated by the Dependency Analysis Gradle plugin, this PR removes all unused dependencies from this project.FYI: As part of this change, the Dependency Analysis Gradle plugin got also updated to its latest 1.33.0 version.
Testing Steps
./gradlew buildHealthtask and verify that there is nounusedrelated advise remaining within both reports, JSON and txt included:build-health-report.json-> Search forunusedCountbuild-health-report.txt-> Search forunusedLogin, or via composite builds, and see if it works as expected.