Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dependency Update] Update a8c-ci-toolkit to 3.4.2 #151

Merged
merged 2 commits into from
Jul 12, 2024

Conversation

ParaskP7
Copy link
Contributor

Description

This PR updates a8c-ci-toolkit to 3.4.2.

FYI: The breaking change in 3.0.0 is due to removing the nvm_install command, but this repo doesn't use that anywhere anyway. As such, it is safe to apply this update.

Testing Instructions

  • Make sure CI is green (🟢).

Release Notes: https://github.com/Automattic/
a8c-ci-toolkit-buildkite-plugin/releases/tag/3.4.2

------------------------------------------------------------------------

FYI: The breaking change in '3.0.0' is due to removing the 'nvm_install'
command, but this repo doesn't use that anywhere anyway. As such, it is
safe to apply this update.
@ParaskP7 ParaskP7 requested a review from a team July 12, 2024 10:33
@AliSoftware
Copy link
Contributor

Same as Automattic/pocket-casts-android#2487 (review), would love to use the opportunity to start using shared-pipeline-vars in this repo 🙂

For more info see: https://github.com/wordpress-mobile/
WordPress-Login-Flow-Android/pull/151#issuecomment-2225299197
@ParaskP7
Copy link
Contributor Author

FYI @AliSoftware that this is now done: 04d046a

Copy link
Contributor

@AliSoftware AliSoftware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@ParaskP7 ParaskP7 merged commit 693312b into trunk Jul 12, 2024
8 checks passed
@ParaskP7 ParaskP7 deleted the deps/update-a8c-ci-toolkit-to-3.4.2 branch July 12, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants