Bump :gravatar to 2.0.0 #21311
Open
Bump :gravatar to 2.0.0 #21311
+49
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamGrzybkowski
added
the
Do Not Merge
Generated by 🚫 Danger |
Project dependencies changesThe following changes in project dependencies were detected (configuration listtree-+--- project :libs:login
-| \--- com.gravatar:gravatar:0.2.0 -> 1.0.0
-| +--- com.squareup.retrofit2:retrofit:2.9.0 -> 2.11.0
-| | \--- com.squareup.okhttp3:okhttp:3.14.9 -> 4.12.0 (*)
-| +--- com.squareup.retrofit2:converter-gson:2.9.0
-| | +--- com.squareup.retrofit2:retrofit:2.9.0 -> 2.11.0 (*)
-| | \--- com.google.code.gson:gson:2.8.5 -> 2.11.0 (*)
-| +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.7.3 -> 1.8.1 (*)
-| +--- com.squareup.okhttp3:okhttp:4.12.0 (*)
-| \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.22 -> 2.0.0 (*)
++--- project :libs:image-editor
+| \--- com.google.android.material:material:1.12.0
+| \--- org.jetbrains.kotlin:kotlin-bom:1.8.22
+| \--- org.jetbrains.kotlin:kotlin-reflect:1.8.22 (c)
-+--- com.gravatar:gravatar:1.0.0 (*)
-\--- com.zendesk:support:5.1.2
- \--- com.zendesk:support-providers:5.1.2
- \--- com.zendesk:core:4.0.9
- \--- com.squareup.retrofit2:converter-gson:2.9.0 (*)
++--- project :libs:login
+| \--- com.gravatar:gravatar:2.0.0
+| +--- com.squareup.moshi:moshi-kotlin:1.15.1
+| | +--- com.squareup.moshi:moshi:1.15.1
+| | | +--- com.squareup.okio:okio:3.7.0 -> 3.9.0 (*)
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.21 -> 1.9.10 (*)
+| | +--- org.jetbrains.kotlin:kotlin-reflect:1.8.21 -> 1.8.22
+| | | \--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 2.0.0 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.21 -> 1.9.10 (*)
+| +--- com.squareup.retrofit2:retrofit:2.11.0
+| | \--- com.squareup.okhttp3:okhttp:3.14.9 -> 4.12.0 (*)
+| +--- com.squareup.retrofit2:converter-moshi:2.11.0
+| | +--- com.squareup.retrofit2:retrofit:2.11.0 (*)
+| | \--- com.squareup.moshi:moshi:1.15.1 (*)
+| +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.7.3 -> 1.8.1 (*)
+| +--- com.squareup.okhttp3:okhttp:4.12.0 (*)
+| \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.25 -> 2.0.0 (*)
++--- com.gravatar:gravatar:2.0.0 (*)
+\--- com.zendesk:support:5.1.2
+ \--- com.zendesk:support-providers:5.1.2
+ \--- com.zendesk:core:4.0.9
+ \--- com.squareup.retrofit2:converter-gson:2.9.0
+ +--- com.squareup.retrofit2:retrofit:2.9.0 -> 2.11.0 (*)
+ \--- com.google.code.gson:gson:2.8.5 -> 2.11.0 (*) |
|
 |
App Name |  WordPress |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr21311-926eb61 | |
| Commit | 926eb61 | |
| Direct Download | wordpress-prototype-build-pr21311-926eb61.apk |
|
 |
App Name |  Jetpack |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr21311-926eb61 | |
| Commit | 926eb61 | |
| Direct Download | jetpack-prototype-build-pr21311-926eb61.apk |
AdamGrzybkowski
force-pushed
the
adam/gravatar_2.0.0
branch
from
c7e807e
to
53bc90f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #21311 +/- ##
==========================================
- Coverage 39.31% 39.30% -0.01%
==========================================
Files 2121 2121
Lines 98303 98311 +8
Branches 15227 15227
==========================================
Hits 38644 38644
- Misses 56224 56232 +8
Partials 3435 3435 ☔ View full report in Codecov by Sentry. |
AdamGrzybkowski
added
Gravatar
AdamGrzybkowski
force-pushed
the
adam/gravatar_2.0.0
branch
from
53bc90f
to
926eb61
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps the Gravatar SDK to the latest 2.0.0 version.
On the outside, we made some updates to our public API but under the hood, the avatar upload endpoint was also updated to a v3 version.
Note: I have an issue with one screen during sign-up flow
SignupEpilogueFragment. When I runwasabiflavor this screen automatically finishes and moves to the next one. Testing thejalapenobuild seems to work fine. I've also asked @hamorillo to test this and it worked okay for him on both variants. Any idea what's happening? I can see the thewasabibuild is getting someAccountAction.PUSH_SETTINGSupdates.To Test:
Avatar change flow from the
MeFragmentandSignupEpilogueFragment.SignupEpilogueFragmentscreen.Regression Notes
Potential unintended areas of impact
PR Submission Checklist:
- [ ] I have completed the Regression Notes.RELEASE-NOTES.txtif necessary.Testing Checklist (strike-out the not-applying and unnecessary ones):
- [ ] WordPress.com sites and self-hosted Jetpack sites.- [ ] Portrait and landscape orientations.- [ ] Light and dark modes.- [ ] Fonts: Larger, smaller and bold text.- [ ] High contrast.- [ ] Talkback.- [ ] Languages with large words or with letters/accents not frequently used in English.- [ ] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)- [ ] Large and small screen sizes. (Tablet and smaller phones)- [ ] Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)The update is shouldn't affect the UI so the above scenarios are not valid.