✨ connect home layout to server via API #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kmkim2689
commented
Jul 25, 2024
kmkim2689
commented
- implement server connection from server
- edit home layout components
Hogu59
approved these changes
Jul 25, 2024
ii2001
requested changes
Jul 25, 2024
| val authorImage: String, | ||
| @SerializedName("authorName") | ||
| val authorName: String, | ||
| ) |
There was a problem hiding this comment.
SerializedName을 추가해야하나요? 어차피 변수명이랑 똑같은데
| import net.pengcook.android.presentation.detail.RecipeStep | ||
| import retrofit2.Response | ||
|
|
||
| class DefaultFeedRepository( |
There was a problem hiding this comment.
기본 구현체 이름에 prefix로 Default를 붙이기로 저희 팀 컨벤션으로 정했기에 붙였습니다!
| } | ||
| throw IllegalArgumentException() | ||
| } | ||
| } |
There was a problem hiding this comment.
이것도 다른 파일로 혹시 옮겨주실수있나요?
그 가능하다면 ViewModelFactory 생성 base코드 만들어 주면 너무 감사할것같습니다.
|
수고하셨습니다. |
ii2001
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.