-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FE] 약속 입장, 약속 현황 조회 페이지(달력)의 웹 접근성을 개선 #421
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
참여자 탭을 클릭할 때마다 aria-label에 '참여자가 선택한 일정 확인하기' 문구를 추가하여 스크린 리더 사용자에게 현재 선택된 상태를 명확히 전달하도록 개선
.storybook/preview.tsx에서 모든 스토리에 대해 ToastProvider로 컴포넌트를 감싸도록 설정
Test Results35 tests 35 ✅ 23s ⏱️ Results for commit 787a8a6. |
Largopie
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
빙봉이랑 작업 같이함 ^_^ 😊
hwinkr
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ 접근성 고생하셨어용 ㅎㅎ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
작업 내용
웹 접근성 개선 과정은 아래의 문서를 참고해 주세요. 개선 전, 개선 후에 관란 동영상 자료가 많아서 노션 문서 링크로 대체합니다!
약속 입장, 약속 현황 조회 페이지(달력)의 웹 접근성을 개선 과정을 작성한 문서
특이 사항
리뷰 요구사항 (선택)