로그인하지 않아도 사용자 페이지 접근 가능하도록 RouteGuard 제거 #891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vi-wolhwa
approved these changes
Nov 1, 2024
Jaymyong66
approved these changes
Nov 1, 2024
| @@ -1,6 +1,7 @@ | |||
| import styled from '@emotion/styled'; | |||
|
|
|||
| import { Button } from '@/components'; | |||
| import { theme } from '@/style/theme'; | |||
There was a problem hiding this comment.
다만, 이렇게 정적 파일 변수를 import해서 쓴다면 이제 ThemeProvider를 쓸 필요가 없는 걸까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚡️ 관련 이슈
📍주요 변경 사항
RouteGuard 제거
참고로 존재하지 않는 멤버 아이디로 접근할 시 아래와 같이 404 페이지가 보입니다.
🎸기타
🍗 PR 첫 리뷰 마감 기한
10/31
ZZZZZAP!! 오늘 안에 main 까지 올려서 재배포 하면 좋을 것 같아요!