좋아요한 템플릿 목록 페이지 생성 및 캐로셀 스크롤로 변경 #872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jaymyong66
approved these changes
Oct 24, 2024
Comment on lines
+22
to
+51
| useEffect(() => { | ||
| const sentinel = sentinelRef.current; | ||
|
|
||
| if (!sentinel) { | ||
| return; | ||
| } | ||
|
|
||
| const observerOptions: IntersectionObserverInit = { | ||
| root: null, | ||
| rootMargin: '0px', | ||
| threshold: [0, 1.0], | ||
| }; | ||
|
|
||
| const observerCallback: IntersectionObserverCallback = (entries) => { | ||
| // entries[0].isIntersecting이 false일 때 (sentinel이 화면에서 벗어났을 때) 버튼 보여줌 | ||
| const entry = entries[0]; | ||
| const shouldShow = !entry.isIntersecting || entry.intersectionRatio < 1; | ||
|
|
||
| void setIsVisible(shouldShow); | ||
| }; | ||
|
|
||
| const observer = new IntersectionObserver(observerCallback, observerOptions); | ||
|
|
||
| observer.observe(sentinel); | ||
|
|
||
| // eslint-disable-next-line consistent-return | ||
| return () => { | ||
| observer.disconnect(); | ||
| }; | ||
| }, []); |
Comment on lines
+63
to
+68
| <Flex direction='column' gap='0.5rem'> | ||
| <S.EllipsisTextWrapper> | ||
| <Text.XLarge color={theme.color.light.secondary_900} weight='bold'> | ||
| {title} | ||
| </Text.XLarge> | ||
| </S.EllipsisTextWrapper> |
| <Heading.XLarge color={theme.color.light.primary_500}>403 ERROR</Heading.XLarge> | ||
| <Flex direction='column' gap='2rem' align='center'> | ||
| <Text.XLarge color={theme.color.light.primary_500} weight='bold'> | ||
| 죄송합니다. 해당 페이지에 접근할 수 있는 권한이 없습니다. |
There was a problem hiding this comment.
사소하지만 '죄송합니다.' 표현이 없어도 될 것 같다는 생각이네요 ㅎㅎ
Comment on lines
+1
to
+16
| import { Link, useParams } from 'react-router-dom'; | ||
|
|
||
| import { Flex, Heading, LoadingBall, NoResults, PagingButtons, TemplateCard } from '@/components'; | ||
| import { useQueryParams, useWindowWidth } from '@/hooks'; | ||
| import { useAuth } from '@/hooks/authentication'; | ||
| import { ForbiddenPage } from '@/pages'; | ||
| import { useLikedTemplateListQuery } from '@/queries/templates/useLikedTemplateListQuery'; | ||
| import { ROUTE_END_POINT } from '@/routes/endPoints'; | ||
| import { useTrackPageViewed } from '@/service/amplitude'; | ||
|
|
||
| import { TemplateListSectionLoading } from '../MyTemplatesPage/components'; | ||
| import * as S from './MyLikedTemplatePage.style'; | ||
|
|
||
| const getGridCols = (windowWidth: number) => (windowWidth <= 1024 ? 1 : 2); | ||
|
|
||
| const MyLikedTemplatePage = () => { |
There was a problem hiding this comment.
해당 페이지는 중복이 많아 추후 리팩토링이 필요해보이네요~!
| return isSearching ? <NoSearchResults /> : <NewTemplateButton />; | ||
| return isSearching ? <NoResults>검색 결과가 없습니다.</NoResults> : <NewTemplateButton />; |
| @@ -28,3 +29,21 @@ export const END_POINTS = { | |||
| LOGIN_CHECK: '/login/check', | |||
| CHECK_NAME: '/check-name', | |||
| } as const; | |||
|
|
|||
| export const ROUTE_END_POINT = { | |||
There was a problem hiding this comment.
변수명은 ROUTE만 있어도 좋을 것 같고, 어느 부분에는 적용이 되어있지 않은 것 같아서 이것도 리팩토링 목록으로 넣어두겠습니당
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚡️ 관련 이슈
close - #846
📍주요 변경 사항
🎸기타
🍗 PR 첫 리뷰 마감 기한
10/24