[BE] 비밀번호 재설정 기능을 구현한다. #843
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shin-jisong
requested changes
Oct 21, 2024
| @@ -30,12 +38,16 @@ public class AuthService { | |||
|
|
|||
| private static final Logger log = LoggerFactory.getLogger(AuthService.class); | |||
| private static final int GUEST_USER_LIMIT = 1; | |||
| private static final int PASSWORD_RESET_CODE_EXPIRED_MINUTES = 3; | |||
There was a problem hiding this comment.
5분 혹은 10분이 적당하지 않을까요?!
| } | ||
|
|
||
| userRepository.updatePasswordByEmail( | ||
| new Email(request.email()), new Password(request.newPassword())); |
There was a problem hiding this comment.
여기서 패스워드 리셋 코드 저장한 걸 삭제하는 건 어떨까요?!
Comment on lines
+36
to
+37
| void updatePasswordByEmail(@Param("email") Email email, @Param("newPassword") Password newPassword); | ||
|
|
There was a problem hiding this comment.
로그인 타입도 지정해 줘야 될 것 같아요!
| @Autowired | ||
| private PasswordResetCodeRepository passwordResetCodeRepository; | ||
|
|
||
| @DisplayName("특정 시간보다 나중에 생성된 비밀번호 초기화 코드 존재 시 참 반환") |
There was a problem hiding this comment.
컨벤션이랑 살짝 다른 것 같아서 확인해 주세요!
tsulocalize
reviewed
Oct 21, 2024
| .hasMessage(ExceptionCode.AUTHENTICATION_PASSWORD_CODE_NOT_FOUND.getMessage()); | ||
| } | ||
|
|
||
| @DisplayName("비밀번호 재설정 선공") |
|
|
||
| class MailSenderTest { | ||
|
|
||
| @DisplayName("이메일 전송 시 send 메소드 호출") |
JINU-CHANG
requested changes
Oct 24, 2024
Comment on lines
+15
to
+18
| @Getter | ||
| @NoArgsConstructor(access = PROTECTED) | ||
| @Entity | ||
| public class PasswordResetCode extends BaseEntity { |
There was a problem hiding this comment.
일회성 데이터 같아서 DB에 저장할 필요는 없다고 생각되는데 혹시 다른 방식 고민해보신게 있나요??
Comment on lines
+3
to
+4
| public record ConfirmPasswordResetCodeRequest(String email, String code) { | ||
| } |
| @@ -109,6 +121,31 @@ public void logout(String accessToken, String refreshToken, User user) { | |||
| validateTokenOwnership(user, accessAuthUser, refreshAuthUser); | |||
| } | |||
|
|
|||
| public void sendPasswordResetEmail(ForgotPasswordRequest request) { | |||
There was a problem hiding this comment.
@transactional 빠진 것 같아요 👀
Comment on lines
+48
to
+50
| private final MailSender mailSender; | ||
| private final PasswordResetCodeRepository passwordResetCodeRepository; | ||
| private final Clock clock; |
There was a problem hiding this comment.
비밀번호 찾기에 대한 코드량이 상당한 것 같은데 새로운 서비스로 분리해보는 건 어떨까요? 해당 클래스들이 의존성을 가질 수 있겠네요!
|
|
||
| @Value("${spring.mail.properties.mail.smtp.debug}") | ||
| private boolean debug; | ||
|
|
| return ResponseEntity.noContent().build(); | ||
| } | ||
|
|
||
| @PostMapping("/v1/password-reset/new-password") |
There was a problem hiding this comment.
Suggested change
| @PostMapping("/v1/password-reset/new-password") | |
| @PostMapping("/v1/password-reset") |
마지막은 new-password 단어를 빼도 의미전달이 될 것 같은데 어떠신가용
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ Issue
✨ 구현한 기능
📢 논의하고 싶은 내용
🎸 기타
LocalDateTime 테스트를 위해 Clock을 빈으로 등록했습니다.
yml파일 mail관련 설정 업데이트 예저입니다.