refactor: vo,엔티티 리팩터링 #483

Kim0914 · 2024-01-02T07:13:54Z

※ 해당 PR 및 커밋은 이건회(@rawfishthelgh )와 함께 몹 프로그래밍으로 작성했습니다

🔥 연관 이슈

close 인증, 사전식물, 회원, 반려식물 도메인에서 VO 활용, Mapper 제거 #482

🚀 작업 내용

리팩토링을 진행했습니다 🌱

엔티티 필드 값 객체 래핑
Mapper 계층 -> request, response로 이동
사소한 컨벤션 수정

곧 패키지 구조도 함께 변경할 계획입니다.

💬 리뷰 중점사항

큰 변경사항은 없습니다. 🙇🏻

github-actions · 2024-01-02T07:15:58Z

Unit Test Results

  87 files ±0   87 suites ±0 14s ⏱️ -2s
364 tests ±0 364 ✔️ ±0 0 💤 ±0 0 ❌ ±0
370 runs ±0 370 ✔️ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 820c9f0. ± Comparison against base commit 78ab7ae.

♻️ This comment has been updated with latest results.

rawfishthelgh

확인했습니당ㅎㅎ

Choi-JJunho

고생하셨습니다~
머지 전에 자잘한 부분 코멘트확인만 부탁드릴게요!!!

Choi-JJunho · 2024-01-02T07:15:52Z

backend/pium/src/main/java/com/official/pium/domain/DictionaryPlant.java

-    @Column(name = "special_manage_info")
-    private String specialManageInfo;
+    @Embedded
+    private Property property;


A

Property로 묶으니까 확실히 깔끔하네요! 👍

Choi-JJunho · 2024-01-02T07:16:11Z

backend/pium/src/main/java/com/official/pium/domain/DictionaryPlant.java


    @Embedded
-    private WaterCycle waterCycle;
+    private CareDetail careDetail;


A

CareDetail 이름 좋은데요? 👍

Choi-JJunho · 2024-01-02T07:18:50Z

backend/pium/src/main/java/com/official/pium/domain/PetPlant.java

-    @Column(name = "last_water_date", nullable = false)
-    private LocalDate lastWaterDate;
+    @Embedded
+    private WaterDate waterDate;


A

WaterDate도 좋은 것 같은데 물주기 요소들이 묶여있다는 의미가 와닿지 않는것 같습니다. (@Embedded느낌보다는 하나의 Column같은 느낌이네요)
위에서 선언했던 CareDetail이라는 명칭처럼 WaterDetail은 어떨까요?

오호 좋습니다 ! 반영하게융

Choi-JJunho · 2024-01-02T07:20:52Z

backend/pium/src/main/java/com/official/pium/event/history/PetPlantHistory.java

-        return null;
+        return Optional.empty();


A

null 반환 대신 Optional.empty 반환 좋네요 👍

Choi-JJunho · 2024-01-02T07:21:53Z

backend/pium/src/main/java/com/official/pium/repository/DictionaryPlantRepository.java

@@ -6,5 +6,5 @@

 public interface DictionaryPlantRepository extends JpaRepository<DictionaryPlant, Long> {

-    List<DictionaryPlant> findDictionaryPlantsByNameContains(String name);
+    List<DictionaryPlant> findDictionaryPlantsByClassification_NameContains(String name);


A

_가 들어가있는게 다소 어색해보이긴한데 CRUDRepository 명명 규약이여서 어쩔수 없으려나요 😅

메소드가 다소 지저분해보여서 되려 사용하는 쪽에서 가독성이 떨어질 수도 있겠다는 생각이 들어요 🥺
JPQL을 사용하는 방식은 어떤가요?

// 예시코드 @Query("SELECT dp FROM DictionaryPlant dp WHERE dp.name LIKE %:name%") List<DictionaryPlant> searchDictionaryPlantsByName(String name);

헉 좋은데요?
이 부분 할까말까 했었는데 바로 진행시켰씁니다 ㅎㅎ

yeonkkk

하마드, 그레이 고생 많으셨습니다!
컨벤션 관련 코멘트랑 궁금한 점 조금 남겨봤어요.
필요하다고 느껴지시면 수정하시고 merge 하시면 될 것 같습니다!
고생하셨어요 ~

그리고 다들 새복많~~

yeonkkk · 2024-01-02T07:18:31Z

backend/pium/src/main/java/com/official/pium/controller/PetPlantController.java

        PetPlantResponse petPlantResponse = petPlantService.create(request, multipartFile, member);
        return ResponseEntity.created(URI.create("/pet-plants/" + petPlantResponse.getId())).build();
    }

    @GetMapping
-    public ResponseEntity<DataResponse<List<SinglePetPlantResponse>>> readAll(
-            @Auth Member member) {
+    public ResponseEntity<DataResponse<List<SinglePetPlantResponse>>> readAll(@Auth Member member) {


c

controller 파라미터 컨벤션을 맞추고 계신 것 같은데, 여기는 다른 변경 사항들이랑 반대로 된 것 같아요!
파라미터가 한 개라 이렇게 수정했나 했는데, 다른 컨트롤러 보니까 아니네유

Suggested change

public ResponseEntity<DataResponse<List<SinglePetPlantResponse>>> readAll(@Auth Member member) {

public ResponseEntity<DataResponse<List<SinglePetPlantResponse>>> readAll(

@Auth Member member

) {

아 이거는 한 라인수 넘어가는 것들만 컨벤션 맞추도록 수정했어요 ㅎㅎ

57번째 라인은 안넘어가서 놔뒀답니다 !

yeonkkk · 2024-01-02T07:30:28Z

backend/pium/src/main/java/com/official/pium/domain/DictionaryPlant.java

-                            String requireHumidity, String postingPlace, String specialManageInfo,
-                            WaterCycle waterCycle) {
-        this.name = name;
+    public DictionaryPlant(


A

접근제어자를 public으로 변경한 이유가 있나요? 생성자를 직접 사용하는 곳은 없는 것 같아서요!

넵 반영하겠슴다 !

yeonkkk · 2024-01-02T07:36:50Z

backend/pium/src/main/java/com/official/pium/domain/vo/CareDetail.java

+    private WaterCycle waterCycle;
+
+    @Builder
+    public CareDetail(


A

여기도 접근자가 public 이네영

cf. #61

yeonkkk · 2024-01-02T07:37:30Z

backend/pium/src/main/java/com/official/pium/domain/vo/Classification.java

+    private String familyName;
+
+    @Builder
+    public Classification(String name, String familyName) {


A

동일함다

죄송함다

yeonkkk · 2024-01-02T07:43:02Z

backend/pium/src/main/java/com/official/pium/domain/vo/PetPlantState.java

+    private PetPlantState(String location, String flowerpot, String light, String wind) {
+        validateEmptyValue(location);
+        validateEmptyValue(flowerpot);
+        validateEmptyValue(light);
+        validateEmptyValue(wind);


A

각 필드에 @NotBlank 애너테이션을 붙여주고 nullable =false 조건을 넣어줬는데, 검증 메서드를 따로 작성한 이유가 있나유?!

@NotBlank는 영속성 컨텍스트에 객체가 들어가야 검증이 되는 부분이었습니다 ㅎㅎ
그래서 애플리케이션 내 순수한 도메인 검증도 함께 해주기 위해 작성했었습니다 😀

yeonkkk · 2024-01-02T07:44:10Z

backend/pium/src/main/java/com/official/pium/domain/vo/Property.java

+    private String growSpeed;
+
+    @Builder
+    public Property(String smell, String poison, String manageLevel, String growSpeed) {


A

여기두영

yeonkkk · 2024-01-02T07:44:35Z

backend/pium/src/main/java/com/official/pium/domain/vo/Temperature.java

+    private String minimumTemp;
+
+    @Builder
+    public Temperature(String requireTemp, String minimumTemp) {


A

여기두영

yeonkkk · 2024-01-02T07:53:03Z

backend/pium/src/main/java/com/official/pium/service/dto/DictionaryPlantCreateRequest.java

+        return CareDetail.builder()
+                .temperature(
+                        toTemperature()
+                )
+                .requireHumidity(
+                        this.requireHumidity
+                )
+                .postingPlace(
+                        this.postingPlace
+                )
+                .specialManageInfo(
+                        this.specialManageInfo
+                )
+                .waterCycle(
+                        toWaterCycle()
+                )
+                .build();


A

이건 개인적인 궁금증인데유. 왜 이 친구들은 줄바꿈들이 되어있나요?? ㅎㅎ

리팩터링하다가 빼먹었네욤 ㅎㅎ 통일시키겠씁니다 !!!

yeonkkk · 2024-01-02T07:57:51Z

backend/pium/src/main/java/com/official/pium/domain/DictionaryPlant.java

+    @Embedded
+    private Classification classification;

-    @Column(name = "special_manage_info")
-    private String specialManageInfo;
+    @Embedded
+    private Property property;

    @Embedded
-    private WaterCycle waterCycle;
+    private CareDetail careDetail;


A

이렇게 묶으니까 코드 리뷰하는 입장에서 정말 좋네요!! 코드도 깔끔해지고 가독성 완전 좋아요. 근데 리팩토링하면서 힘들었을 것 같아요 ㅋㅋㅋㅠ 고생하셨습니다 ㅎㅎ

소중한 리뷰 너무 감사드리옵니다 🙇🏻

Kim0914 added 5 commits December 28, 2023 15:23

fix: 세션 그룹 테스트 객체 값 수정

c0dde1a

refactor: 사전 식물 필드 VO 래핑

988a3d8

refactor: 모두의 정원 VO 래핑

90f8ce8

refactor: petPlant 정원 VO 래핑

2a8bd71

refactor: history Mapper 삭제 및 컨벤션에 맞도록 수정

9512fad

Kim0914 added 🛠️ 리팩터링 리팩터링을 위한 이슈입니다 🍉 백엔드 백엔드 관련 이슈입니다 labels Jan 2, 2024

Kim0914 requested review from Choi-JJunho, rawfishthelgh and yeonkkk January 2, 2024 07:13

Kim0914 assigned Kim0914 and rawfishthelgh Jan 2, 2024

rawfishthelgh approved these changes Jan 2, 2024

View reviewed changes

Choi-JJunho approved these changes Jan 2, 2024

View reviewed changes

yeonkkk approved these changes Jan 2, 2024

View reviewed changes

rawfishthelgh added 4 commits January 2, 2024 17:18

refactor: WaterDate -> WaterDetail 네이밍 변경

f5410f0

refactor: 사전 식물 검색 메소드 네이밍 변경

60dbbf9

refactor: 불필요한 public 생성자 private으로 변경

5d6ab7f

refactor: 불필요 줄바꿈 수정

820c9f0

rawfishthelgh merged commit ec03b0b into develop Jan 2, 2024
4 checks passed

rawfishthelgh deleted the refactor/482-VO,엔티티_리팩터링 branch January 2, 2024 08:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: vo,엔티티 리팩터링 #483

refactor: vo,엔티티 리팩터링 #483

Kim0914 commented Jan 2, 2024 •

edited by rawfishthelgh

Loading

github-actions bot commented Jan 2, 2024 •

edited

Loading

rawfishthelgh left a comment

Choi-JJunho left a comment

Choi-JJunho Jan 2, 2024

Choi-JJunho Jan 2, 2024

Choi-JJunho Jan 2, 2024

Kim0914 Jan 2, 2024

Choi-JJunho Jan 2, 2024

Choi-JJunho Jan 2, 2024

Kim0914 Jan 2, 2024

yeonkkk left a comment

yeonkkk Jan 2, 2024

Kim0914 Jan 2, 2024

yeonkkk Jan 2, 2024

Kim0914 Jan 2, 2024

yeonkkk Jan 2, 2024

yeonkkk Jan 2, 2024

Kim0914 Jan 2, 2024

yeonkkk Jan 2, 2024

Kim0914 Jan 2, 2024

yeonkkk Jan 2, 2024

yeonkkk Jan 2, 2024

yeonkkk Jan 2, 2024

Kim0914 Jan 2, 2024

yeonkkk Jan 2, 2024

Kim0914 Jan 2, 2024

refactor: vo,엔티티 리팩터링 #483

refactor: vo,엔티티 리팩터링 #483

Conversation

Kim0914 commented Jan 2, 2024 • edited by rawfishthelgh Loading

🔥 연관 이슈

🚀 작업 내용

💬 리뷰 중점사항

github-actions bot commented Jan 2, 2024 • edited Loading

Unit Test Results

rawfishthelgh left a comment

Choose a reason for hiding this comment

Choi-JJunho left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

A

Choose a reason for hiding this comment

A

Choose a reason for hiding this comment

A

Choose a reason for hiding this comment

Choose a reason for hiding this comment

A

Choose a reason for hiding this comment

A

Choose a reason for hiding this comment

yeonkkk left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

c

Choose a reason for hiding this comment

Choose a reason for hiding this comment

A

Choose a reason for hiding this comment

Choose a reason for hiding this comment

A

Choose a reason for hiding this comment

A

Choose a reason for hiding this comment

Choose a reason for hiding this comment

A

Choose a reason for hiding this comment

Choose a reason for hiding this comment

A

Choose a reason for hiding this comment

A

Choose a reason for hiding this comment

A

Choose a reason for hiding this comment

Choose a reason for hiding this comment

A

Choose a reason for hiding this comment

Kim0914 commented Jan 2, 2024 •

edited by rawfishthelgh

Loading

github-actions bot commented Jan 2, 2024 •

edited

Loading