-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AN/USER] 유저 어플 클린아키텍쳐 적용 (#650) #651
+498
−333
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
69599dd
chore(data): 데이터 레이어 추가
re4rk a67e01e
chore(presentation): 프레젠테이션 레이어 추가
re4rk d15ad07
chore(common): common 레이어 추가
re4rk a343498
refactor(common): analytics를 common 레이어 밑으로 이동
re4rk 8edf2bb
refactor(common): analytics의 모듈 변경
re4rk 71d4989
refactor(data): app에서 data 레이어로 이동
re4rk ff4cb5c
refactor(presentation): app에서 presentation 레이어로 이동
re4rk f32380a
refactor(presentation): 리소스 경로 presentation으로 이동
re4rk 30b6460
refactor(presentation): 테스트 케이스 presentation으로 이동
re4rk 55e48de
chore(app): 사용하지 않는 build.gradle.kts 정리
re4rk 0d10f56
chore(gradle): 추가 된 내옹 제거
re4rk 5e7fc76
refactor: ktlint 적용
re4rk b8447aa
refactor(data): 파일 경로와 패키지명 일치
re4rk cdc656b
refactor(data): ktlint 적용
re4rk dfb314b
fix(data): 모듈 변경 후 통과하지 못하는 테스트 케이스 수정
re4rk 9581c4d
fix(gradle): 그래들 빌드 실패 케이스 통과하게 수정
re4rk 403a582
refactor(common): di 의존성 각 모듈에서 담당하도록 변경
re4rk 0b92261
refactor(app): app 사용 하지 않는 의존성 정리
re4rk 9f3083a
chore(common): 사용하지 않는 의존성 정리
re4rk 7ff301a
refactor(presentation): 파일 수정시 절대 경로가 입력되는 현상 수정
re4rk a567028
refactor(app): 카카오 sdk 초기화를 presentation splash에서 하도록 변경
re4rk 745dd68
refactor(docs): docs 제거
re4rk acb5fd3
refactor(presentation): 레거시 테스트 제거
re4rk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
69 changes: 0 additions & 69 deletions
69
...om/festago/festago/presentation/ui/reservationcomplete/ReservationCompleteActivityTest.kt
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
/build |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
plugins { | ||
id("com.android.library") | ||
id("org.jetbrains.kotlin.android") | ||
kotlin("kapt") | ||
} | ||
|
||
android { | ||
namespace = "com.festago.festago.common" | ||
compileSdk = 34 | ||
|
||
defaultConfig { | ||
minSdk = 26 | ||
consumerProguardFiles("consumer-rules.pro") | ||
} | ||
|
||
buildTypes { | ||
release { | ||
isMinifyEnabled = false | ||
proguardFiles( | ||
getDefaultProguardFile("proguard-android-optimize.txt"), | ||
"proguard-rules.pro", | ||
) | ||
} | ||
} | ||
compileOptions { | ||
sourceCompatibility = JavaVersion.VERSION_17 | ||
targetCompatibility = JavaVersion.VERSION_17 | ||
} | ||
kotlinOptions { | ||
jvmTarget = "17" | ||
} | ||
} | ||
|
||
kotlin.jvmToolchain(17) | ||
|
||
dependencies { | ||
// hilt | ||
implementation("com.google.dagger:hilt-android:2.44") | ||
kapt("com.google.dagger:hilt-android-compiler:2.44") | ||
|
||
// firebase | ||
implementation(platform("com.google.firebase:firebase-bom:32.2.0")) | ||
implementation("com.google.firebase:firebase-analytics-ktx") | ||
implementation("com.google.firebase:firebase-crashlytics-ktx") | ||
implementation("com.google.firebase:firebase-messaging-ktx:23.2.1") | ||
} |
Empty file.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
common 모듈에 어떤 코드가 위치하게 되는건지 잘 이해하지 못했어요! analytics 로깅 관련 코드가 이곳으로 옮겨진 것 같은데 현재 presentation 레이어에서만 로그를 남기고 있으니 presentation에서만 필요한 코드 아닌가요??
app -> common
,data -> common
의존이 왜 필요한지 궁금!이후에 data나 app에서 common 모듈을 사용하게 되는걸까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
�현재 analytics는 presentation만 사용되고 있지만 팀내에서 모든 레이어에서 로깅하기로 했기 때문에 모든 모듈에서 접근 가능한 모듈을 작성을 해야 했습니다!
현재 app, domain, data, presentation 모듈 모두 접근 가능한 모듈에 배치하시 위해서는 domain 레이어가 가장 적합하다고 판단이 되었지만 analytics는 안드로이드 의존성을 가지고 있습니다. 그래서 저희는 domain 레이어는 코틀린 라이브러리로 두기로 하여서 별도의 모듈이 필요하다고 생각하였습니다.