Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/#684 request notification update notification 삭제 #685

Conversation

java-saeng
Copy link
Collaborator

#️⃣연관된 이슈

📝작업 내용

RequestNotification, RequestNotification 삭제

예상 소요 시간 및 실제 소요 시간

예상 : 10/7
실제 : 10/5

file changed가 많은 이유는 삭제할게 많아서입니다.
따로 로직 수정한거 없고, 삭제만 했습니다.

@java-saeng java-saeng added Backend 백엔드 관련 이슈 리팩터링 테스트 코드의 검증 값이 변환하지 않고 코드 변경 labels Oct 5, 2023
@java-saeng java-saeng added this to the 6차 스프린트 milestone Oct 5, 2023
@java-saeng java-saeng self-assigned this Oct 5, 2023
Copy link
Collaborator

@amaran-th amaran-th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~!
크게 눈에 띄는 부분은 없는 것 같네요.

Copy link
Collaborator

@hyeonjerry hyeonjerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

하나하나 다 찾아서 지우시느라 고생 많으셨겠네요,,
수고하셨습니다~!

Copy link
Collaborator

@hong-sile hong-sile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

엄청난 노가다를 하셨군요. 수고하셨습니다!!

@java-saeng java-saeng merged commit 5ac1d37 into backend-main Oct 6, 2023
1 check passed
@chws0508 chws0508 deleted the Refactor/#684-RequestNotification_UpdateNotification_삭제 branch October 11, 2023 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend 백엔드 관련 이슈 리팩터링 테스트 코드의 검증 값이 변환하지 않고 코드 변경
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants