Feature/#664 행사 dto의 image url을 s3의 데이터로 대체 #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
September 25, 2023 15:14
…rse-teams/2023-emmsale into Feature/#664-행사_다단건_조회_시_S3의_이미지를_반환하도록_수정
- EventDetailRequest에서 imageUrl 제거 #664
amaran-th
added
Backend
…github.com/woowacourse-teams/2023-emmsale into Feature/#664-행사_DTO의_imageUrl을_S3의_데이터로_대체
- 행사 진행 상태, 남은 일 수 제거 #664
- 행사 진행 상태, 남은 일 수 제거 #664
java-saeng
approved these changes
Oct 8, 2023
java-saeng
approved these changes
Oct 8, 2023
hyeonjerry
reviewed
Oct 8, 2023
| @@ -44,6 +44,7 @@ public class EventDetailResponse { | |||
| public static EventDetailResponse from( | |||
| final Event event, | |||
| final LocalDate today, | |||
| final String imageUrl, | |||
There was a problem hiding this comment.
개인적으로 imageUrl이라고 하는 것 보다 thumbnailUrl이라고 하는게 더 명확하게 의미를 전달할 수 있을 것 같아요.
There was a problem hiding this comment.
의견 반영해서 EventDetailResponse, EventResponse의 imageUrl을 thumbnailUrl로 이름 변경했습니다!
hyeonjerry
approved these changes
Oct 8, 2023
| @@ -592,7 +647,7 @@ void addEventWithStartDateTimeAfterBeforeDateTimeTest() { | |||
| final EventException exception = assertThrowsExactly(EventException.class, | |||
| () -> eventService.addEvent(request, mockMultipartFiles, now)); | |||
|
|
|||
| assertEquals(exception.exceptionType(), START_DATE_TIME_AFTER_END_DATE_TIME); | |||
| assertEquals(START_DATE_TIME_AFTER_END_DATE_TIME, exception.exceptionType()); | |||
added 2 commits
October 9, 2023 18:31
…023-emmsale into Feature/#664-행사_DTO의_imageUrl을_S3의_데이터로_대체
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
#664
📝작업 내용
EventDetailResponse(행사 상세 조회)의 imageUrl과 imageUrls를 각각 S3 이미지의 섬네일 이미지, 나머지 이미지가 반환되도록 구현했습니다.
EventResponse(행사 목록 조회)의 imageUrl을 S3이미지의 섬네일 이미지가 반환되도록 구현했습니다.
EventDetailRequest(행사 생성/수정)의 imageUrl 필드를 제거했습니다.
Event의 imageUrl 컬럼을 제거했습니다.
예상 소요 시간 및 실제 소요 시간
9/27
9/28
💬리뷰 요구사항(선택)
리뷰 범위1, 리뷰 범위2입니다!
아래는 요구사항은 아니고 메모입니다.
*제리의 #657 PR 내역을 pull 받고 작업했기 때문에 제리의 PR이 머지된 후 해당 PR을 머지해야 합니다.